-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Fix the link in rustdoc.md
#143438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the link in rustdoc.md
#143438
Conversation
Thanks! However, I don't think the new link is correct. This file is rendered at https://doc.rust-lang.org/nightly/rustdoc.html, and it is trying to link to the Rust Book. However, it is currently going to the older link at https://doc.rust-lang.org/nightly/book/documentation.html. I think this would either link to @GuillaumeGomez do you have a preference? |
If we're talking about working on rustdoc, I'd link to https://rustc-dev-guide.rust-lang.org/rustdoc-internals.html. If it's about using rustdoc, I'd link to https://doc.rust-lang.org/rustdoc/what-is-rustdoc.html. |
Yea, this is for users. You can see what the old docs looked like at https://doc.rust-lang.org/0.11.0/rustdoc.html. |
This comment has been minimized.
This comment has been minimized.
0a0f5d9
to
4dfbb09
Compare
4dfbb09
to
be9669f
Compare
Thanks! @bors r+ rollup |
Rollup of 9 pull requests Successful merges: - #132469 (Do not suggest borrow that is already there in fully-qualified call) - #143340 (awhile -> a while where appropriate) - #143438 (Fix the link in `rustdoc.md`) - #143539 (Regression tests for repr ICEs) - #143566 (Fix `x86_64-unknown-netbsd` platform support page) - #143572 (Remove unused allow attrs) - #143583 (`loop_match`: fix 'no terminator on block') - #143584 (make `Machine::load_mir` infallible) - #143591 (Fix missing words in future tracking issue) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #143438 - makai410:rustdoc-fix, r=ehuss Fix the link in `rustdoc.md`
No description provided.