Skip to content

Regression tests for repr ICEs #143539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

JonathanBrouwer
Copy link
Contributor

Closes #143522
Closes #143479

Both issues were already (accidentally) fixed in this PR, but having the tests is nice #143252

r? @jdonszelmann

Signed-off-by: Jonathan Brouwer <[email protected]>
@rustbot
Copy link
Collaborator

rustbot commented Jul 6, 2025

jdonszelmann is not on the review rotation at the moment.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 6, 2025
@JonathanBrouwer
Copy link
Contributor Author

r? @oli-obk
Jana won't have time the coming days

@rustbot rustbot assigned oli-obk and unassigned jdonszelmann Jul 7, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jul 7, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 7, 2025

📌 Commit f7046bd has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2025
bors added a commit that referenced this pull request Jul 7, 2025
Rollup of 9 pull requests

Successful merges:

 - #132469 (Do not suggest borrow that is already there in fully-qualified call)
 - #143340 (awhile -> a while where appropriate)
 - #143438 (Fix the link in `rustdoc.md`)
 - #143539 (Regression tests for repr ICEs)
 - #143566 (Fix `x86_64-unknown-netbsd` platform support page)
 - #143572 (Remove unused allow attrs)
 - #143583 (`loop_match`: fix 'no terminator on block')
 - #143584 (make `Machine::load_mir` infallible)
 - #143591 (Fix missing words in future tracking issue)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6c8482e into rust-lang:master Jul 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 7, 2025
rust-timer added a commit that referenced this pull request Jul 7, 2025
Rollup merge of #143539 - JonathanBrouwer:ice-regression-tests, r=oli-obk

Regression tests for repr ICEs

Closes #143522
Closes #143479

Both issues were already (accidentally) fixed in this PR, but having the tests is nice #143252

r? `@jdonszelmann`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: #![repr] ICE with repr(align(0))
5 participants