Skip to content

Test failing deserialization of invalid sequence length #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Test failing deserialization of invalid sequence length #261

merged 2 commits into from
Jul 3, 2025

Conversation

MiguelCompany
Copy link
Contributor

@MiguelCompany MiguelCompany commented May 28, 2025 •
edited
Loading

Description

This adds tests the changes in the following PRs:

Is this user-facing behavior change?

Did you use Generative AI?

NO

Additional Information

Note: when launching CI, remember to include rmw_fastrtps_dynamic_cpp

fujitatomoya
fujitatomoya approved these changes May 29, 2025
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fujitatomoya
Copy link
Collaborator

Pulls: #261, ros2/rosidl_typesupport_fastrtps#130, ros2/rmw_fastrtps#827
Gist: https://gist.githubusercontent.com/fujitatomoya/e0ac7267ca82f4c2ccdf079ea0b9b628/raw/b106bbdcfa1746ef8a713236addb3b5d5bfc277a/ros2.repos
BUILD args: --packages-above-and-dependencies test_rmw_implementation rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rmw_fastrtps_dynamic_cpp
TEST args: --packages-above test_rmw_implementation rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rmw_fastrtps_dynamic_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16121

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced May 29, 2025
Merged
Merged
@MiguelCompany
Copy link
Contributor Author

Had to re-run the CI, enabling rmw_fastrtps_dynamic_cpp.

CI launcher: https://ci.ros2.org/job/ci_launcher/16127

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@MiguelCompany
Copy link
Contributor Author

New CI after fixing linter issues:

CI launcher: https://ci.ros2.org/job/ci_launcher/16149/

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@MiguelCompany
Copy link
Contributor Author

MiguelCompany commented Jun 9, 2025 •
edited
Loading

New CI after rebasing ros2/rmw_fastrtps#827

CI launcher: https://ci.ros2.org/job/ci_launcher/16360/

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@MiguelCompany
Copy link
Contributor Author

MiguelCompany commented Jul 1, 2025 •
edited
Loading

New CI with correct repos file

CI launcher: https://ci.ros2.org/job/ci_launcher/16395

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@MiguelCompany
Copy link
Contributor Author

@fujitatomoya CI looks good to me, I think the failing tests are unrelated. If you think the same, would you mind merging this along with ros2/rosidl_typesupport_fastrtps#130 and ros2/rmw_fastrtps#827 ?

@fujitatomoya
Copy link
Collaborator

@MiguelCompany CI failures are unrelated and those are known and instable failures. i will go ahead to merge all PRs.

@fujitatomoya fujitatomoya merged commit 4dd5d57 into ros2:rolling Jul 3, 2025
2 of 3 checks passed
@fujitatomoya
Copy link
Collaborator

@Mergifyio backport kilted jazzy humble

@mergify Mergify
Copy link

mergify bot commented Jul 3, 2025 •
edited
Loading

backport kilted jazzy humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 3, 2025
@MiguelCompany @mergify
Test failing deserialization of invalid sequence length (#261)
627a7bc 
* Add test infrastructure.

Signed-off-by: Miguel Company <[email protected]>

* Test that deserialization with wrong sequence length fails.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 4dd5d57)
@mergify mergify bot mentioned this pull request Jul 3, 2025
Merged
mergify bot pushed a commit that referenced this pull request Jul 3, 2025
@MiguelCompany @mergify
Test failing deserialization of invalid sequence length (#261)
ae837cb 
* Add test infrastructure.

Signed-off-by: Miguel Company <[email protected]>

* Test that deserialization with wrong sequence length fails.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 4dd5d57)
mergify bot pushed a commit that referenced this pull request Jul 3, 2025
@MiguelCompany @mergify
Test failing deserialization of invalid sequence length (#261)
767f1cd 
* Add test infrastructure.

Signed-off-by: Miguel Company <[email protected]>

* Test that deserialization with wrong sequence length fails.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 4dd5d57)

# Conflicts:
#	test_rmw_implementation/test/test_serialize_deserialize.cpp
This was referenced Jul 3, 2025
Merged
Open
fujitatomoya pushed a commit that referenced this pull request Jul 18, 2025
@mergify @MiguelCompany
Test failing deserialization of invalid sequence length (#261) (#263)
a7db732 
* Add test infrastructure.



* Test that deserialization with wrong sequence length fails.



---------


(cherry picked from commit 4dd5d57)

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
fujitatomoya pushed a commit that referenced this pull request Jul 18, 2025
@mergify @MiguelCompany
Test failing deserialization of invalid sequence length (#261) (#262)
7ec12a4 
* Add test infrastructure.



* Test that deserialization with wrong sequence length fails.



---------


(cherry picked from commit 4dd5d57)

Signed-off-by: Miguel Company <[email protected]>
Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @fujitatomoya