Skip to content

Test failing deserialization of invalid sequence length (backport #261) #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: humble
Choose a base branch
from
Open

Test failing deserialization of invalid sequence length (backport #261) #264

wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 3, 2025

Description

This adds tests the changes in the following PRs:

Is this user-facing behavior change?

Did you use Generative AI?

NO

Additional Information

Note: when launching CI, remember to include rmw_fastrtps_dynamic_cpp

This is an automatic backport of pull request #261 done by Mergify.

@MiguelCompany @mergify
Test failing deserialization of invalid sequence length (#261)
767f1cd 
* Add test infrastructure.

Signed-off-by: Miguel Company <[email protected]>

* Test that deserialization with wrong sequence length fails.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 4dd5d57)

# Conflicts:
#	test_rmw_implementation/test/test_serialize_deserialize.cpp
@mergify mergify bot added the conflicts label Jul 3, 2025
@mergify Mergify
Copy link
Author

mergify bot commented Jul 3, 2025

Cherry-pick of 4dd5d57 has failed:

On branch mergify/bp/humble/pr-261
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 4dd5d57.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test_rmw_implementation/test/test_serialize_deserialize.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Jul 3, 2025
Merged
@fujitatomoya
resolve conflicts.
b6e6ff4 
Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya
Copy link
Collaborator

fujitatomoya commented Jul 4, 2025 •
edited
Loading

Pulls: #264, ros2/rosidl_typesupport_fastrtps#133, ros2/rmw_fastrtps#836
Gist: https://gist.githubusercontent.com/fujitatomoya/5c059c043fddba5002c02988ccf97eb0/raw/a9b9b24f17a5a1215b416882ac1f59b52e890296/ros2.repos
BUILD args: --packages-above-and-dependencies test_rmw_implementation rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rmw_fastrtps_dynamic_cpp
TEST args: --packages-above test_rmw_implementation rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rmw_fastrtps_dynamic_cpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16411

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Jul 4, 2025
Open
Open
@fujitatomoya
Copy link
Collaborator

Pulls: #264, ros2/rosidl_typesupport_fastrtps#133, ros2/rmw_fastrtps#836
Gist: https://gist.githubusercontent.com/fujitatomoya/a4ceab23cd099670f7ec06b4e42b0b8a/raw/a9b9b24f17a5a1215b416882ac1f59b52e890296/ros2.repos
BUILD args: --packages-above-and-dependencies test_rmw_implementation rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rmw_fastrtps_dynamic_cpp
TEST args: --packages-above test_rmw_implementation rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rmw_fastrtps_dynamic_cpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16657

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@MiguelCompany
Copy link
Contributor

MiguelCompany commented Jul 31, 2025 •
edited
Loading

Relaunched with CI_USE_FASTRTPS_DYNAMIC:

Pulls: #264, ros2/rosidl_typesupport_fastrtps#133, ros2/rmw_fastrtps#836
Gist: https://gist.githubusercontent.com/fujitatomoya/a4ceab23cd099670f7ec06b4e42b0b8a/raw/a9b9b24f17a5a1215b416882ac1f59b52e890296/ros2.repos
BUILD args: --packages-above-and-dependencies test_rmw_implementation rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rmw_fastrtps_dynamic_cpp
TEST args: --packages-above test_rmw_implementation rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rmw_fastrtps_dynamic_cpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16658

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
conflicts requires-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujitatomoya @MiguelCompany @wjwwood