Draft: Update [TEST ONLY] inapp module to 0.10.4-alpha.1 #24
Conversation
WalkthroughThe changes update the dependency for Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
package.json (1)
64-73: Fix malformed repository / issue / homepage URLs
All three URLs end with a duplicated “.git” suffix (.git.git), which breaks npm’s “repository” link, GitHub issue redirection, and the badge shown on the npm page.- "url": "git+https://github.com/reclaimprotocol/reclaim-inapp-reactnative-sdk.git.git" + "url": "git+https://github.com/reclaimprotocol/reclaim-inapp-reactnative-sdk.git" - "url": "https://github.com/reclaimprotocol/reclaim-inapp-reactnative-sdk.git/issues" + "url": "https://github.com/reclaimprotocol/reclaim-inapp-reactnative-sdk/issues" - "homepage": "https://github.com/reclaimprotocol/reclaim-inapp-reactnative-sdk.git#readme", + "homepage": "https://github.com/reclaimprotocol/reclaim-inapp-reactnative-sdk#readme",This is a low-effort fix that prevents 404s and improves package metadata.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
InappRnSdk.podspec(1 hunks)package.json(1 hunks)
🔇 Additional comments (1)
package.json (1)
3-3: Version bump looks correct
Theversionfield now matches the new native-SDK tag (0.10.4-alpha.1). No action needed here.
| @@ -17,7 +17,7 @@ Pod::Spec.new do |s| | |||
|
|
|||
| s.source_files = "ios/**/*.{h,m,mm,cpp,swift}" | |||
| s.private_header_files = "ios/generated/**/*.h" | |||
| s.dependency "ReclaimInAppSdk", "~> 0.10.3" | |||
| s.dependency 'ReclaimInAppSdk', :git => 'https://github.com/reclaimprotocol/reclaim-inapp-ios-sdk.git', :tag => '0.10.4-alpha.1' | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Avoid hard-coding the tag – use s.version for automatic synchronisation
Today the dependency matches, but at the next bump it will drift unless both files are updated in lock-step. Let CocoaPods resolve the tag from the spec’s own version instead:
- s.dependency 'ReclaimInAppSdk', :git => 'https://github.com/reclaimprotocol/reclaim-inapp-ios-sdk.git', :tag => '0.10.4-alpha.1'
+ s.dependency 'ReclaimInAppSdk',
+ :git => 'https://github.com/reclaimprotocol/reclaim-inapp-ios-sdk.git',
+ :tag => s.versionThat keeps the podspec single-source-of-truth and removes a future maintenance pit-fall.
🤖 Prompt for AI Agents
In InappRnSdk.podspec at line 20, the dependency tag is hard-coded to
'0.10.4-alpha.1', which can cause version drift. Replace the fixed tag with
s.version to automatically synchronize the dependency version with the podspec's
version. Modify the dependency declaration to use the version variable instead
of a hard-coded string, ensuring the podspec remains the single source of truth
for the version.
predatorx7
changed the title
Summary by CodeRabbit