Updates inapp module dependency to 0.10.3 #23
Conversation
WalkthroughThis update increments the inapp SDK dependency version from 0.10.2 to 0.10.3 across configuration, documentation, and sample files. It also updates migration and installation instructions, changelog, and related links to reference the new version. No changes were made to exported or public entities. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Docs
participant BuildSystem
Developer->>Docs: Reads updated installation/migration instructions (0.10.3)
Developer->>BuildSystem: Updates dependencies to 0.10.3 in project files
BuildSystem-->>Developer: Installs/uses inapp SDK v0.10.3
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (8)
package.json (1)
65-67: Minor: duplicate “.git” suffix in repository URLUnrelated to this bump but visible in the surrounding context:
"url": "git+https://github.com/reclaimprotocol/reclaim-inapp-reactnative-sdk.git.git"The double “.git” may confuse tooling that parses the URL. Consider trimming the extra suffix in a follow-up PR.
android/build.gradle (1)
121-121: Centralise library version to avoid driftGreat on updating to
0.10.3. To prevent future mismatches (Gradle vs Cocoapods vs JS), you may want to expose a singleINAPP_SDK_VERSIONGradle property and reference it here and inext, mirroring what you already do for Kotlin.samples/example_expo/package.json (1)
45-45: Version pinned – differs from caret in other sampleThis sample pins the exact SDK version, whereas
example_new_archuses a caret. Pick one approach for consistency (see comment in the other sample).README.md (1)
139-147: Consider preserving the 0.10.2 migration link or explicitly stating it is unchanged.Dropping the
0.10.2bullet removes an otherwise-useful reference for teams that have not yet upgraded from0.10.2. Either keep the historical link or add a short note that0.10.3contains the same steps as0.10.2.CHANGELOG.md (1)
1-6: Polish wording & consistency in the new 0.10.3 entry.Minor copy tweaks keep the changelog professional and consistent with previous sections:
- * Fix param key text overflow verification review - * Add liveliness checks of javascript calls sent to attestor webview - * Updates inapp module dependency to 0.10.3 +* Fix parameter-key text overflow in the verification-review UI +* Add liveness checks for JavaScript calls sent to the attestor web-view +* Update in-app module dependency to 0.10.3Notes
- “parameter-key”, “verification-review UI”, and “in-app” match earlier wording.
- “liveness” (vs. liveliness) is the industry term.
- Trailing periods omitted to stay consistent with other versions.
documentation/migration.md (1)
5-39: Grammar and spelling fixes for repeated advisory sentence.The same sentence appears in multiple sections; it reads awkwardly and has a typo (“overriden”). Suggested replacement (apply everywhere this sentence occurs):
-Make sure if you are using the latest versions of `ReclaimInAppSdk` cocoapod if you have overriden this dependency in your `Podfile`. +If you override this dependency in your `Podfile`, ensure you are using the latest version of the `ReclaimInAppSdk` CocoaPod.This:
• Removes the double-conditional “make sure if”.
• Fixes “overriden” → “overridden”.
• Capitalises “CocoaPod”.documentation/install-no-framework.md (2)
137-146: Minor style tweaks for pod declarations.
- Add a blank line before code-blocks to satisfy
markdownlintrule MD032 (lists & blocks).- Keep the code fences on their own lines for readability:
-##### From a specific tag - -```ruby -pod 'ReclaimInAppSdk', :git => 'https://github.com/reclaimprotocol/reclaim-inapp-ios-sdk.git', :tag => '0.10.3' -``` +##### From a specific tag + +```ruby +pod 'ReclaimInAppSdk', :git => 'https://github.com/reclaimprotocol/reclaim-inapp-ios-sdk.git', :tag => '0.10.3' +```This silences MD032 / MD034 warnings and keeps formatting consistent with other blocks.
181-184: Duplicate pod declaration – ensure single source of truth.The example
Podfilenow contains two identicalpod 'ReclaimInAppSdk', '~> 0.10.3'lines (one earlier in the Overriding SDK dependency section and one in the sampletarget). Keeping both may lead to merge-conflict noise. Consider keeping only the one inside the sampletargetblock.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
CHANGELOG.md(1 hunks)InappRnSdk.podspec(1 hunks)README.md(1 hunks)android/build.gradle(1 hunks)documentation/install-no-framework.md(2 hunks)documentation/migration.md(3 hunks)package.json(1 hunks)samples/example_expo/package.json(1 hunks)samples/example_new_arch/package.json(1 hunks)
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[grammar] ~1-~1: Use correct spacing
Context: ## 0.10.3 * Fix param key text overflow verificatio...
(QB_NEW_EN_OTHER_ERROR_IDS_5)
[grammar] ~3-~3: There might be a mistake here.
Context: ...ix param key text overflow verification review * Add liveliness checks of javascript c...
(QB_NEW_EN_OTHER)
[grammar] ~4-~4: Use proper capitalization
Context: ...ation review * Add liveliness checks of javascript calls sent to attestor webview * Update...
(QB_NEW_EN_OTHER_ERROR_IDS_6)
[grammar] ~4-~4: There might be a mistake here.
Context: ...ks of javascript calls sent to attestor webview * Updates inapp module dependency to 0....
(QB_NEW_EN_OTHER)
[grammar] ~5-~5: There might be a problem here.
Context: ...script calls sent to attestor webview * Updates inapp module dependency to 0.10.3 ## 0....
(QB_NEW_EN_MERGED_MATCH)
[grammar] ~5-~5: There might be a problem here.
Context: ...ew * Updates inapp module dependency to 0.10.3 ## 0.10.2 * Add humanized summary of values shown i...
(QB_NEW_EN_MERGED_MATCH)
documentation/migration.md
[grammar] ~7-~7: There might be a problem here.
Context: ...running pod update ReclaimInAppSdk. - Refer: https://github.com/reclaimprotocol/reclaim-inapp-reactnative-sdk/blob/main/README.md#ios-setup ## 0.9.2 - Make sure if you are using the latest v...
(QB_NEW_EN_MERGED_MATCH)
[grammar] ~13-~13: There might be a problem here.
Context: ...running pod update ReclaimInAppSdk. - Refer: https://github.com/reclaimprotocol/reclaim-inapp-reactnative-sdk/blob/main/README.md#ios-setup ## 0.9.1 - Make sure if you are using the latest v...
(QB_NEW_EN_MERGED_MATCH)
[grammar] ~19-~19: There might be a problem here.
Context: ...running pod update ReclaimInAppSdk. - Refer: https://github.com/reclaimprotocol/reclaim-inapp-reactnative-sdk/blob/main/README.md#ios-setup ## 0.9.0 - Make sure if you are using the latest v...
(QB_NEW_EN_MERGED_MATCH)
[grammar] ~25-~25: There might be a problem here.
Context: ...running pod update ReclaimInAppSdk. - Refer: https://github.com/reclaimprotocol/reclaim-inapp-reactnative-sdk/blob/main/README.md#ios-setup ## 0.8.3 - Make sure if you are using the latest v...
(QB_NEW_EN_MERGED_MATCH)
[grammar] ~31-~31: There might be a problem here.
Context: ...running pod update ReclaimInAppSdk. - Refer: https://github.com/reclaimprotocol/reclaim-inapp-reactnative-sdk/blob/main/README.md#ios-setup ## 0.7.3 ### iOS - Make sure if you are using the latest v...
(QB_NEW_EN_MERGED_MATCH)
[grammar] ~155-~155: Use articles correctly
Context: ...re if you are using the 0.2.0 version of ReclaimInAppSdk cocoapod if you have ...
(QB_NEW_EN_OTHER_ERROR_IDS_11)
[grammar] ~155-~155: Ensure spelling is correct
Context: ... ReclaimInAppSdk cocoapod if you have overriden this dependency in your Podfile. Late...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
documentation/install-no-framework.md
[grammar] ~142-142: Use correct spacing> 0.10.3'
Context: ... ' ##### From a specific tag ruby pod 'ReclaimInAppSdk', :git => 'https://github.com/reclaimprotocol/reclaim-inapp-ios-sdk.git', :tag => '0.10.3' ##### From git HEAD ruby pod 'ReclaimInAp...
(QB_NEW_EN_OTHER_ERROR_IDS_5)
🪛 markdownlint-cli2 (0.17.2)
documentation/migration.md
7-7: Bare URL used
(MD034, no-bare-urls)
13-13: Bare URL used
(MD034, no-bare-urls)
19-19: Bare URL used
(MD034, no-bare-urls)
25-25: Bare URL used
(MD034, no-bare-urls)
31-31: Bare URL used
(MD034, no-bare-urls)
🔇 Additional comments (3)
InappRnSdk.podspec (1)
20-20: Pod dependency bumped – verify CocoaPods repo updateThe switch to
~> 0.10.3looks correct. Please ensure the 0.10.3 pod has already been pushed to the private/public spec repo; otherwisepod installwill fail for fresh check-outs.package.json (1)
3-3: SDK version bump acknowledgedVersion updated to
0.10.3. LGTM provided CHANGELOG and git tag are in place.documentation/migration.md (1)
155-156: Out-of-date version reference inside the 0.2.1 iOS note.The line still tells users to “make sure if you are using the
0.2.0version” while the surrounding docs promote0.10.3. Update the referenced version (or drop it) to avoid confusion.
| @@ -11,7 +11,7 @@ | |||
| "test": "jest" | |||
| }, | |||
| "dependencies": { | |||
| "@reclaimprotocol/inapp-rn-sdk": "^0.10.2", | |||
| "@reclaimprotocol/inapp-rn-sdk": "^0.10.3", | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Align version-range strategy across sample apps
This sample uses a caret (^0.10.3) while samples/example_expo/package.json pins the exact version (0.10.3). Mixing range strategies makes it harder to reason about which SDK revision is actually installed when developers switch between the two demos.
Consider pinning the version here as well for reproducible installs, or switch both samples to a consistent range spec—either way, pick one strategy and stick to it.
- "@reclaimprotocol/inapp-rn-sdk": "^0.10.3",
+ "@reclaimprotocol/inapp-rn-sdk": "0.10.3",Run the script below to spot any other mismatched specs:
🏁 Script executed:
#!/bin/bash
rg --no-heading -n '"@reclaimprotocol/inapp-rn-sdk":' samples | sortLength of output: 242
Pin SDK version in example_new_arch for consistency
To keep installs reproducible and avoid confusion between demos, both sample apps should use the same version-range strategy for @reclaimprotocol/inapp-rn-sdk. The example_expo app pins the SDK to "0.10.3", so we should do the same in example_new_arch.
Affected file:
- samples/example_new_arch/package.json (line 14)
Suggested change:
- "@reclaimprotocol/inapp-rn-sdk": "^0.10.3",
+ "@reclaimprotocol/inapp-rn-sdk": "0.10.3",Verification output:
samples/example_expo/package.json:45: "@reclaimprotocol/inapp-rn-sdk": "0.10.3"
samples/example_new_arch/package.json:14: "@reclaimprotocol/inapp-rn-sdk": "^0.10.3",
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@reclaimprotocol/inapp-rn-sdk": "^0.10.3", | |
| "@reclaimprotocol/inapp-rn-sdk": "0.10.3", |
🤖 Prompt for AI Agents
In samples/example_new_arch/package.json at line 14, the version of
@reclaimprotocol/inapp-rn-sdk is specified with a caret (^0.10.3), which allows
minor version upgrades. To ensure consistency and reproducible installs with the
example_expo app, change the version to be pinned exactly to "0.10.3" by
removing the caret prefix.
Summary by CodeRabbit
Bug Fixes
Chores
Documentation