Skip to content

Draft: Update [TEST ONLY] inapp module to 0.10.4-alpha.1 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Draft: Update [TEST ONLY] inapp module to 0.10.4-alpha.1 #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion InappRnSdk.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Pod::Spec.new do |s|

s.source_files = "ios/**/*.{h,m,mm,cpp,swift}"
s.private_header_files = "ios/generated/**/*.h"
s.dependency "ReclaimInAppSdk", "~> 0.10.3"
s.dependency 'ReclaimInAppSdk', :git => 'https://github.com/reclaimprotocol/reclaim-inapp-ios-sdk.git', :tag => '0.10.4-alpha.1'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Avoid hard-coding the tag – use s.version for automatic synchronisation

Today the dependency matches, but at the next bump it will drift unless both files are updated in lock-step. Let CocoaPods resolve the tag from the spec’s own version instead:

-  s.dependency 'ReclaimInAppSdk', :git => 'https://github.com/reclaimprotocol/reclaim-inapp-ios-sdk.git', :tag => '0.10.4-alpha.1'
+  s.dependency 'ReclaimInAppSdk', 
+               :git => 'https://github.com/reclaimprotocol/reclaim-inapp-ios-sdk.git',
+               :tag => s.version

That keeps the podspec single-source-of-truth and removes a future maintenance pit-fall.

🤖 Prompt for AI Agents 
In InappRnSdk.podspec at line 20, the dependency tag is hard-coded to
'0.10.4-alpha.1', which can cause version drift. Replace the fixed tag with
s.version to automatically synchronize the dependency version with the podspec's
version. Modify the dependency declaration to use the version variable instead
of a hard-coded string, ensuring the podspec remains the single source of truth
for the version.


# Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
# See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@reclaimprotocol/inapp-rn-sdk",
"version": "0.10.3",
"version": "0.10.4-alpha.1",
"description": "Reclaim Protocol's InApp React Native SDK for ZK proof generations for requests with an in-app experience of web verification",
"source": "./src/index.ts",
"main": "./lib/commonjs/index.js",
Expand Down