Temporarily restore spdlog and fmt#917
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.12from Sep 30, 2025
Merged
Temporarily restore spdlog and fmt#917rapids-bot[bot] merged 3 commits intorapidsai:branch-25.12from
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.12from
Conversation
vyasr
added
bug
bdice
approved these changes
Sep 29, 2025
Contributor
Author
|
/merge |
vyasr
added a commit
to vyasr/rapids-cmake
that referenced
this pull request
Sep 30, 2025
This reverts commit fdc49ad.
7 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 3, 2025
This PR reverts #917 to remove the intended functionality. The corresponding new release of rapids-logger 0.2.0 should ensure compatibility. We're moving straight to 0.2.1 because it has a bugfix we need. Resolves rapidsai/rapids-logger#46 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Bradley Dice (https://github.com/bdice) URL: #918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Until we get a release of rapids-logger out that doesn't depend on the current spdlog behavior RAPIDS builds need these functions in place. This PR is a temporary patch to reduce the urgency of getting that rapids-logger release out.
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))