Skip to content

Remove spdlog and fmt and move to rapids-logger 0.2.1#918

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.12from
vyasr:chore/remove_spdlog_fmt
Oct 3, 2025
Merged

Remove spdlog and fmt and move to rapids-logger 0.2.1#918
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.12from
vyasr:chore/remove_spdlog_fmt

Conversation

@vyasr
Copy link
Copy Markdown
Contributor

@vyasr vyasr commented Sep 30, 2025

Description

This PR reverts #917 to remove the intended functionality. The corresponding new release of rapids-logger 0.2.0 should ensure compatibility. We're moving straight to 0.2.1 because it has a bugfix we need.

Resolves rapidsai/rapids-logger#46

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@vyasr vyasr self-assigned this Sep 30, 2025
@vyasr vyasr requested review from a team as code owners September 30, 2025 23:24
@vyasr vyasr requested review from KyleFromNVIDIA and removed request for a team September 30, 2025 23:24
@vyasr vyasr added breaking Introduces a breaking change improvement Improves an existing functionality labels Sep 30, 2025
@vyasr vyasr marked this pull request as draft September 30, 2025 23:24
@vyasr
Copy link
Copy Markdown
Contributor Author

vyasr commented Oct 1, 2025

This PR can merge once we have packages up. We have wheels, but the conda packages are currently only on the rapidsai conda channel and we need them copied over to the rapidsai-nightly channel.

@vyasr vyasr marked this pull request as ready for review October 1, 2025 23:08
@vyasr vyasr added the DO NOT MERGE Hold off on merging; see PR for details label Oct 1, 2025
@vyasr vyasr changed the title Remove spdlog and fmt and move to rapids-logger 0.2 Remove spdlog and fmt and move to rapids-logger 0.2.1 Oct 1, 2025
@vyasr vyasr removed the DO NOT MERGE Hold off on merging; see PR for details label Oct 1, 2025
@vyasr
Copy link
Copy Markdown
Contributor Author

vyasr commented Oct 2, 2025

Packages are up now, so this PR can be merged. I'd like to have PRs ready to update the rest of RAPIDS dependencies as well.

@vyasr vyasr added DO NOT MERGE Hold off on merging; see PR for details and removed DO NOT MERGE Hold off on merging; see PR for details labels Oct 2, 2025
@vyasr
Copy link
Copy Markdown
Contributor Author

vyasr commented Oct 3, 2025

/merge

@rapids-bot rapids-bot bot merged commit 66c4bcf into rapidsai:branch-25.12 Oct 3, 2025
18 checks passed
@vyasr vyasr deleted the chore/remove_spdlog_fmt branch October 3, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Introduces a breaking change improvement Improves an existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] rapids-logger cannot find spdlog

3 participants