Remove deprecated support for fmt and spdlog#914
Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.12from Sep 25, 2025
Merged
Remove deprecated support for fmt and spdlog#914rapids-bot[bot] merged 5 commits intorapidsai:branch-25.12from
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.12from
Conversation
Member
|
What is the motivation for this? Please link to the build-planning issue. |
Contributor
Author
|
@KyleFromNVIDIA I updated the PR description (needed to look up the issue number). This has been deprecated for a while, with a removal target of 25.12. |
Contributor
Author
|
@vyasr We'll need to fix rapids-logger so that it no longer uses these deprecated features. It looks like you've already done this in rapidsai/rapids-logger#38, but we need to update a version somewhere. I'll look a little further at this. |
KyleFromNVIDIA
approved these changes
Sep 24, 2025
bdice
added
breaking
…g rapids-logger/spdlog which by default requires <format>, which needs a newer GCC version than we can support with CUDA 12.2. Whew.
Contributor
Author
|
/merge |
7 tasks
vyasr
added a commit
to vyasr/rapids-cmake
that referenced
this pull request
Sep 29, 2025
This reverts commit 5ffba3c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes deprecated support for fmt and spdlog. Planned in #813, deprecated in #853.
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))