Skip to content

Conversation

@radarhere
Copy link
Member

pyroma 5.0 has been released, and it is causing failures - https://github.com/python-pillow/Pillow/actions/runs/16298847553/job/46046857802#step:11:5143

This PR

@freakboy3742
Copy link
Contributor

Getting the fix for iOS in place will require an update to the iOS support package, then a cibuildwheel release to make that support package the default version. The former is on my todo list (I'm a little distracted by EuroPython this week); the latter then comes down to cibuildwheel's release cadence, but given 3.14-rc1 will be out shortly, I can't imagine a release would be that far behind.

Comment on lines 319 to 320
finally:
os.remove("embed_pil.c")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add teardown_method to this class to delete it, to save an indent?

https://docs.pytest.org/en/stable/how-to/xunit_setup.html#method-and-function-level-setup-teardown

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've pushed a commit.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk merged commit 640f55a into python-pillow:main Jul 24, 2025
56 checks passed
@hugovk hugovk added the Testing label Jul 24, 2025
@radarhere radarhere deleted the pyroma branch July 24, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants