gh-135966: Modify iOS testbed to make app_packages a site directory #135967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
added
needs backport to 3.13
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 1baae68 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135967%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 27, 2025
…tory (pythonGH-135967) The iOS testbed now treats the app_packages folder as a site folder. This ensures it is on the path, but also ensures any .pth files are processed on app startup. (cherry picked from commit b38810b) Co-authored-by: Russell Keith-Magee <[email protected]>
|
Sorry, @freakboy3742, I could not cleanly backport this to |
|
GH-136012 is a backport of this pull request to the 3.14 branch. |
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Jun 27, 2025
…e directory (pythonGH-135967) The iOS testbed now treats the app_packages folder as a site folder. This ensures it is on the path, but also ensures any .pth files are processed on app startup. (cherry picked from commit b38810b) Co-authored-by: Russell Keith-Magee <[email protected]>
|
GH-136013 is a backport of this pull request to the 3.13 branch. |
freakboy3742
added a commit
that referenced
this pull request
Jun 27, 2025
…ctory (GH-135967) (#136012) The iOS testbed now treats the app_packages folder as a site folder. This ensures it is on the path, but also ensures any .pth files are processed on app startup. (cherry picked from commit b38810b) Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the startup of the iOS testbed so that the
app_packagesfolder is treated as a site directory.This ensures that
.pthfiles that are installed by packaged (such as the setuptools "distutils_hack") will not be processed.This surfaced during testing of an iOS patch for Pillow, which uses pyroma; pyroma depends on distutils; but because the .pth file installed by setuptools isn't processed, distutils can't be imported, and so neither can pyroma.
Also documents this as a likely integration requirement for anyone embedding CPython on iOS.
📚 Documentation preview 📚: https://cpython-previews--135967.org.readthedocs.build/