Conversation
Member
|
Superseded by apache#7674 |
craig-rueda
added a commit
that referenced
this pull request
Nov 20, 2019
* First cut at app factory * Setting things back to master * Working with new FLASK_APP * Still need to refactor Celery * CLI mostly working * Working on unit tests * Moving cli stuff around a bit * Removing get in config * Defaulting test config * Adding flask-testing * flask-testing casing * resultsbackend property bug * Fixing up cli * Quick fix for KV api * Working on save slice * Fixed core_tests * Fixed utils_tests * Most tests working - still need to dig into remaining app_context issue in tests * All tests passing locally - need to update code comments * Fixing dashboard tests again * Blacking * Sorting imports * linting * removing envvar mangling * blacking * Fixing unit tests * isorting * licensing * fixing mysql tests * fixing cypress? * fixing .flaskenv * fixing test app_ctx * fixing cypress * moving manifest processor around * moving results backend manager around * Cleaning up __init__ a bit more * Addressing PR comments * Addressing PR comments * Blacking * Fixes for running celery worker * Tuning isort * Blacking
rusackas
added a commit
that referenced
this pull request
Nov 20, 2019
* Sweep #1 * moving a few more colors, fixing an import issue. * another include, another color nabbed. * more whittling. * moving filterbox css to less, standardizing colors in there. * nixing the css file I meant to nab in the last commit * Moving the variables file to a more global/sensible (I hope?) location. * FilterableTable moved from CSS to LESS, using color vars now. * more whittling * standardizing opacity stops * nails more colors, removes some old (seemingly unused) css * removing more dead css * DatasourceControl moved from CSS to LESS * BootstrapSliderWrapper CSS -> LESS * reactable-pagination CSS->LESS, color-conformed * FilterBadgeIcon CSS->LESS, conformed * deleting unused/deprecated css * welcome.css -> welcome.less (is this even being used?) * main.css -> main.less, standardized * there were two main.css files - this should have been in the last commit. * explore.css -> explore.less (not used anywhere?) * sql.css -> sql.less (also not used anywhere?) * another main.css -> main.less, standardized on colors * time to add shades and tints! * caught some colors in SVG that should be in LESS. * nixing commented css * deleting commented code * pulling in z-index vars lost in a conflict resolution
preset-machine
pushed a commit
that referenced
this pull request
Nov 30, 2021
chore: upgrade to deck.gl 7.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
The
.scrollbar-containerclass used in this view didn't have anyoverflowproperty set. Following the pattern of the instance within.SqlEditorLeftBar, I added.SqlLab{ overflow: auto ;}under.SqlLaband it now seems to behave correctly. This should not affect the class in other contexts.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Create a handful of queries, view the list, and make your window short enough to necessitate scrolling. It should then scroll as intended.
ADDITIONAL INFORMATION
REVIEWERS
@mistercrunch