Resolved SQL Lab Query Search scrolling issue (Fixes #7526)#7674
Merged
mistercrunch merged 1 commit intoapache:masterfrom Jun 9, 2019
Merged
Resolved SQL Lab Query Search scrolling issue (Fixes #7526)#7674mistercrunch merged 1 commit intoapache:masterfrom
mistercrunch merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7674 +/- ##
==========================================
- Coverage 65.59% 65.57% -0.03%
==========================================
Files 437 437
Lines 21787 21787
Branches 2400 2400
==========================================
- Hits 14291 14286 -5
- Misses 7375 7380 +5
Partials 121 121
Continue to review full report at Codecov.
|
12 tasks
etr2460
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 11, 2019
12 tasks
etr2460
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 11, 2019
Fixed SQL Lab Query Search scrolling issue(apache#7526) (apache#7674)
Member
Author
|
🏷 preset-io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
The
.scrollbar-containerclass used in this view didn't have anyoverflowproperty set. Following the pattern of the instance within.SqlEditorLeftBar, I added.SqlLab{ overflow: auto ;}under.SqlLaband it now seems to behave correctly. This should not affect the class in other contexts.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Create a handful of queries, view the list, and make your window short enough to necessitate scrolling. It should then scroll as intended.
ADDITIONAL INFORMATION
REVIEWERS
@mistercrunch