Moving static colors over to Less vars#8563
Merged
mistercrunch merged 35 commits intoapache:masterfrom Nov 20, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8563 +/- ##
=======================================
Coverage 65.77% 65.77%
=======================================
Files 482 482
Lines 23794 23794
Branches 2587 2587
=======================================
Hits 15651 15651
Misses 7974 7974
Partials 169 169
Continue to review full report at Codecov.
|
etr2460
reviewed
Nov 14, 2019
Member
Author
|
I think that's enough for one PR... I'll make additional PRs soon to tackle the following: |
dpgaspar
reviewed
Nov 19, 2019
suddjian
reviewed
Nov 19, 2019
Member
|
Looks awesome, let's merge it! |
suddjian
approved these changes
Nov 19, 2019
Member
Author
|
Just for posterity, here are the color mappings from this PR
|
12 tasks
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Making it easier to change colors around in the future, and catching a few inconsistencies at the same time. Part of a general effort to move "themable" bits into vars for global re-use.