Skip to content

Include FQCN in the Serializable deprecation message (ref #6494) #7343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wouterj
Copy link

@wouterj wouterj commented Aug 5, 2021

While running some of my test suites on PHP 8.1.0-beta2, I (rightfully) received the deprecation introduced by #6494: "The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary)"

The message is very clear on the course of action, but it didn't provide any information to which class was affected by this change. This PR proposes a very small change by adding the affected FQCN in the message.

@nikic
Copy link
Member

nikic commented Aug 11, 2021

Closing this in favor of #7346, which implemented the same change with a slightly different message.

@nikic nikic closed this Aug 11, 2021
@wouterj wouterj deleted the serializable-deprecation-message branch August 11, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants