Partially deprecate Serializable #6494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, looks like |
nikic
force-pushed
the
deprecate-serializable
branch
from
31ccf91 to
807e5c2
Compare
thg2k
reviewed
Dec 7, 2020
|
|
||
| ?> | ||
| --EXPECTF-- | ||
| Deprecated: The Serializable interface is deprecated. If you need to retain the Serializable interface for cross-version compatibility, you can suppress this warning by implementing __serialize() and __unserialize() in addition, which will take precedence over Serializable in PHP versions that support them in %s on line 6 |
There was a problem hiding this comment.
Suggested change
| Deprecated: The Serializable interface is deprecated. If you need to retain the Serializable interface for cross-version compatibility, you can suppress this warning by implementing __serialize() and __unserialize() in addition, which will take precedence over Serializable in PHP versions that support them in %s on line 6 | |
| Deprecated: The Serializable interface is deprecated. For cross-version compatibility, also implement __serialize() and __unserialize() which take precedente over Serializable in %s on line 6 |
There was a problem hiding this comment.
Suggested change
| Deprecated: The Serializable interface is deprecated. If you need to retain the Serializable interface for cross-version compatibility, you can suppress this warning by implementing __serialize() and __unserialize() in addition, which will take precedence over Serializable in PHP versions that support them in %s on line 6 | |
| Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions or serialization payloads needs to be retained) in %s on line 6 |
There was a problem hiding this comment.
I think the main thing I want to convey here is that the alternative is __serialize/__unserialize, and you only need both for supporting multiple versions, otherwise you don't.
nikic
force-pushed
the
deprecate-serializable
branch
from
807e5c2 to
2d81670
Compare
If Serializable is implemented, require that __serialize() and __unserialize() are implemented as well, else issue a deprecation warning.
nikic
force-pushed
the
deprecate-serializable
branch
from
2d81670 to
f811e57
Compare
nikic
force-pushed
the
deprecate-serializable
branch
from
f811e57 to
9154c53
Compare
wouterj
added a commit
to wouterj/php-src
that referenced
this pull request
Aug 5, 2021
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Mar 9, 2022
New sniff which addresses the following deprecation in PHP 8.1: > **Implementing Serializable without `__serialize()` and `__unserialize()`** > > Either only the new methods should be implemented, if no support for PHP prior to version 7.4 is provided, or both should be implemented. This sniff will throw a warning when a class implements the `Serializable` interface, but does not implement the magic `__serialize()` and `__unserialize()` methods. The sniff contains a `public` `$serializableInterfaces` property for users to provide their own list of additional interfaces (which extend the `Serializable` interface) to scan for. If the sniff comes across an interface declaration extending the `Serializable` interface and the interface is not in the user provided `$serializableInterfaces` list, a warning will be thrown for the user to add the interface to the property via a custom ruleset. Additionally, when the `testVersion` has a minimum PHP version of `7.4` or higher, an additional check is executed: * For interfaces directly extending `Serializable` AND containing a declaration of both the `__serialize()` as well as the `__unserialize()` magic method, thus enforcing the implementation of these methods in classes implementing the interface, a warning will be thrown that the extension of the `Serializable` interface can be removed. * For classes which implement the `Serializable` interface AND contain a declaration of both the `__serialize()` as well as the `__unserialize()` magic method, a warning will be thrown that the implementation of the `Serializable` interface can be removed. Includes unit tests. Includes updating the section about available custom properties in the README. Refs: * https://www.php.net/manual/en/migration81.deprecated.php#migration81.deprecated.core.serialize-interface * https://wiki.php.net/rfc/phase_out_serializable * https://www.php.net/manual/en/class.serializable.php * https://www.php.net/manual/en/language.oop5.magic.php#object.serialize * php/php-src#6494 * php/php-src@3e6b447
jrfnl
added a commit
to PHPCompatibility/PHPCompatibility
that referenced
this pull request
Mar 9, 2022
New sniff which addresses the following deprecation in PHP 8.1: > **Implementing Serializable without `__serialize()` and `__unserialize()`** > > Either only the new methods should be implemented, if no support for PHP prior to version 7.4 is provided, or both should be implemented. This sniff will throw a warning when a class implements the `Serializable` interface, but does not implement the magic `__serialize()` and `__unserialize()` methods. The sniff contains a `public` `$serializableInterfaces` property for users to provide their own list of additional interfaces (which extend the `Serializable` interface) to scan for. If the sniff comes across an interface declaration extending the `Serializable` interface and the interface is not in the user provided `$serializableInterfaces` list, a warning will be thrown for the user to add the interface to the property via a custom ruleset. Additionally, when the `testVersion` has a minimum PHP version of `7.4` or higher, an additional check is executed: * For interfaces directly extending `Serializable` AND containing a declaration of both the `__serialize()` as well as the `__unserialize()` magic method, thus enforcing the implementation of these methods in classes implementing the interface, a warning will be thrown that the extension of the `Serializable` interface can be removed. * For classes which implement the `Serializable` interface AND contain a declaration of both the `__serialize()` as well as the `__unserialize()` magic method, a warning will be thrown that the implementation of the `Serializable` interface can be removed. Includes unit tests. Includes updating the section about available custom properties in the README. Refs: * https://www.php.net/manual/en/migration81.deprecated.php#migration81.deprecated.core.serialize-interface * https://wiki.php.net/rfc/phase_out_serializable * https://www.php.net/manual/en/class.serializable.php * https://www.php.net/manual/en/language.oop5.magic.php#object.serialize * php/php-src#6494 * php/php-src@3e6b447
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/phase_out_serializable
If Serializable is implemented, require that __serialize() and
__unserialize() are implemented as well, else issue a deprecation
warning.