Skip to content

Include FQCN in the Serializable deprecation message (ref #6494) #7343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Include FQCN in the Serializable deprecation message (ref #6494) #7343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Zend/tests/bug64354.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ try {
}
?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in B instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
string(9) "serialize"
2 changes: 1 addition & 1 deletion Zend/tests/enum/no-implement-serializable-indirect.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ var_dump(unserialize(serialize(Foo::Bar)));

?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in Foo instead (or in addition, if support for old PHP versions is necessary) in %s on line %d

Fatal error: Enums may not implement the Serializable interface in %s on line %d
2 changes: 1 addition & 1 deletion Zend/tests/enum/no-implement-serializable.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ var_dump(unserialize(serialize(Foo::Bar)));

?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in Foo instead (or in addition, if support for old PHP versions is necessary) in %s on line %d

Fatal error: Enums may not implement the Serializable interface in %s on line %d
2 changes: 1 addition & 1 deletion Zend/tests/serializable_deprecation.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ class D extends A implements I {

?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in C instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
2 changes: 1 addition & 1 deletion Zend/tests/traits/interface_003.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ var_dump(unserialize($o));

?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in bar instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
string(20) "C:3:"bar":6:{foobar}"
string(6) "foobar"
object(bar)#%d (0) {
Expand Down
2 changes: 1 addition & 1 deletion Zend/zend_interfaces.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ static int zend_implement_serializable(zend_class_entry *interface, zend_class_e
}
if (!(class_type->ce_flags & ZEND_ACC_EXPLICIT_ABSTRACT_CLASS)
&& (!class_type->__serialize || !class_type->__unserialize)) {
zend_error(E_DEPRECATED, "The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary)");
zend_error(E_DEPRECATED, "The Serializable interface is deprecated. Implement __serialize() and __unserialize() in %s instead (or in addition, if support for old PHP versions is necessary)", ZSTR_VAL(class_type->name));
}
return SUCCESS;
}
Expand Down
2 changes: 1 addition & 1 deletion ext/pdo/tests/bug_44409.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ print_r($stmt->fetchAll(PDO::FETCH_CLASS|PDO::FETCH_SERIALIZE, "bug44409"));

?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in bug44409 instead (or in addition, if support for old PHP versions is necessary) in %s on line %d

Deprecated: PDOStatement::fetchAll(): The PDO::FETCH_SERIALIZE mode is deprecated in %s on line %d
Method called: bug44409::unserialize('Data from DB')
Expand Down
6 changes: 3 additions & 3 deletions ext/pdo/tests/pdo_018.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,11 @@ var_dump($stmt->fetchAll(PDO::FETCH_CLASS|PDO::FETCH_CLASSTYPE|PDO::FETCH_SERIAL

?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in TestBase instead (or in addition, if support for old PHP versions is necessary) in %s on line %d

Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in TestDerived instead (or in addition, if support for old PHP versions is necessary) in %s on line %d

Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in TestLeaf instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
string(1) "3"
array(3) {
[0]=>
Expand Down
2 changes: 1 addition & 1 deletion ext/pdo_mysql/tests/pdo_mysql_stmt_fetch_serialize.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ $db = MySQLPDOTest::factory();
$db->exec('DROP TABLE IF EXISTS test');
?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in myclass instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Creating an object, serializing it and writing it to DB...
myclass::singleton(Creating object)
myclass::__construct(Creating object)
Expand Down
2 changes: 1 addition & 1 deletion ext/pdo_mysql/tests/pdo_mysql_stmt_fetch_serialize_simple.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ MySQLPDOTest::skip();
print "done!\n";
?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in myclass instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Lets see what the Serializeable interface makes our object behave like...
myclass::__construct('Called by script') - note that it must not be called when unserializing
myclass::serialize()
Expand Down
6 changes: 3 additions & 3 deletions ext/standard/tests/serialize/005.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ echo "===AutoNA===\n";
var_dump(unserialize('O:22:"autoload_not_available":0:{}'));
?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in TestNew instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
===O1===
TestOld::__sleep()
string(18) "O:7:"TestOld":0:{}"
Expand All @@ -153,7 +153,7 @@ object(TestNAOld)#%d (0) {
===NANew===
unserializer(TestNANew)

Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in TestNANew instead (or in addition, if support for old PHP versions is necessary) in %s on line %d

Warning: Erroneous data format for unserializing 'TestNANew' in %s005.php on line %d

Expand All @@ -162,7 +162,7 @@ bool(false)
===NANew2===
unserializer(TestNANew2)

Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in TestNANew2 instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
TestNew::unserialize()
object(TestNANew2)#%d (0) {
}
Expand Down
6 changes: 3 additions & 3 deletions ext/standard/tests/serialize/bug36424.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,11 @@ echo "Done\n";

?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in a instead (or in addition, if support for old PHP versions is necessary) in %s on line %d

Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in b instead (or in addition, if support for old PHP versions is necessary) in %s on line %d

Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in c instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
C:1:"c":108:{a:1:{s:1:"a";C:1:"a":81:{a:3:{s:1:"b";C:1:"b":30:{a:2:{s:1:"c";r:1;s:1:"a";r:3;}}s:1:"c";r:1;s:1:"a";r:3;}}}}
bool(true)
bool(true)
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/serialize/bug64146.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ print $a->a[1]->b->c . "\n";
?>
Done
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in B instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
1
2
Done
2 changes: 1 addition & 1 deletion ext/standard/tests/serialize/bug64354_3.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ try {
}
?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in B instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
string(6) "Failed"
2 changes: 1 addition & 1 deletion ext/standard/tests/serialize/bug65481.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ $token = serialize($token);
?>
Done
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in Token instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Done
2 changes: 1 addition & 1 deletion ext/standard/tests/serialize/bug70172.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function ptr2str($ptr)
}
?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in obj instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
array(2) {
[0]=>
int(1)
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/serialize/bug70172_2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function ptr2str($ptr)
}
?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in obj instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
array(2) {
[0]=>
object(obj2)#%d (1) {
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/serialize/bug70219_1.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var_dump($data);
var_dump($_SESSION);
?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in obj instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
array(2) {
[0]=>
object(obj)#%d (1) {
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/serialize/bug70436.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function ptr2str($ptr)
?>
DONE
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in obj instead (or in addition, if support for old PHP versions is necessary) in %s on line %d

Notice: unserialize(): Error at offset 0 of 3 bytes in %sbug70436.php on line %d

Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/serialize/bug71940.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ print_r(unserialize($serialized));

?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in Entry instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Array
(
[0] => Entry Object
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/serialize/bug72663_2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ var_dump(unserialize($exploit));

?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in obj instead (or in addition, if support for old PHP versions is necessary) in %s on line %d

Notice: unserialize(): Unexpected end of serialized data in %s on line %d

Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/serialize/bug80411.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ var_export($recovered);

?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in UnSerializable instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
a:4:{i:0;N;i:1;N;i:2;s:6:"endcap";i:3;R:4;}
array (
0 => NULL,
Expand Down
4 changes: 2 additions & 2 deletions ext/standard/tests/serialize/max_depth.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ Warning: unserialize(): Maximum depth of 256 exceeded. The depth limit can be ch
Notice: unserialize(): Error at offset 2309 of 2574 bytes in %s on line %d
bool(false)

Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in Test instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Nested unserialize combined depth limit:

Warning: unserialize(): Maximum depth of 256 exceeded. The depth limit can be changed using the max_depth unserialize() option or the unserialize_max_depth ini setting in %s on line %d
Expand All @@ -149,7 +149,7 @@ bool(false)
bool(true)
bool(true)

Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in Test2 instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Nested unserialize overridden depth limit:

Warning: unserialize(): Maximum depth of 256 exceeded. The depth limit can be changed using the max_depth unserialize() option or the unserialize_max_depth ini setting in %s on line %d
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/serialize/ref_to_failed_serialize.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ var_dump(unserialize($s));

?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in NotSerializable instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
string(18) "a:2:{i:0;N;i:1;N;}"
array(2) {
[0]=>
Expand Down
2 changes: 1 addition & 1 deletion ext/standard/tests/serialize/serialization_objects_010.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ try {
echo "Done";
?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in C instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
C::serialize() must return a string or NULL
Done
2 changes: 1 addition & 1 deletion ext/standard/tests/strings/bug72663.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ var_dump(unserialize($exploit));
?>
DONE
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in obj instead (or in addition, if support for old PHP versions is necessary) in %s on line %d

Notice: unserialize(): Unexpected end of serialized data in %sbug72663.php on line %d

Expand Down
2 changes: 1 addition & 1 deletion tests/classes/serialize_001.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ foreach($tests as $data)

?>
--EXPECTF--
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
Deprecated: The Serializable interface is deprecated. Implement __serialize() and __unserialize() in Test instead (or in addition, if support for old PHP versions is necessary) in %s on line %d
==========
string(6) "String"
Test::__construct(String)
Expand Down