test: feature-gate PostgreSQL tests to remove external dependencies from cargo test

[Copilot]

Feature-gate PostgreSQL tests to simplify development

Goal: Make cargo test pass without PostgreSQL running by creating a separate test-pg feature.

Implementation Complete ✅

All PostgreSQL-requiring tests are now feature-gated behind the test-pg feature, which is NOT in the default feature set. This allows developers to run cargo test without setting up PostgreSQL, while CI and integration testing can explicitly enable these tests.

Changes Summary:

1. Feature Definitions

• martin/Cargo.toml: Added test-pg = ["postgres"] feature
• martin-core/Cargo.toml: Added test-pg = ["postgres"] feature
• Both features enable the postgres feature but are NOT in default features

2. Test Files Updated

• martin/tests/pg_function_source_test.rs - Changed from #![cfg(feature = "postgres")] to #![cfg(feature = "test-pg")]
• martin/tests/pg_server_test.rs - Changed from #![cfg(feature = "postgres")] to #![cfg(feature = "test-pg")]
• martin/tests/pg_table_source_test.rs - Changed from #![cfg(feature = "postgres")] to #![cfg(feature = "test-pg")]
• martin/tests/utils.rs - Updated PG helper functions to use test-pg feature
• martin-core/src/tiles/postgres/pool.rs - Changed test module from #[cfg(test)] to #[cfg(all(test, feature = "test-pg"))]
• martin/src/config/file/tiles/postgres/builder.rs - Changed test module from #[cfg(test)] to #[cfg(all(test, feature = "test-pg"))] to gate container-based tests

3. Build System Updates

• justfile: Updated commands to properly pass --features test-pg as separate arguments:
  • test: Runs with "--all-targets" "--features" "test-pg"
  • test-pg: Runs only PostgreSQL-specific tests (integration tests + lib tests with PG gates)
  • test-legacy: Runs with "--all-targets" "--features" "test-pg"
  • test-ssl: Runs with "--all-targets" "--features" "test-pg"
  • coverage: Runs with --all-targets --features test-pg
  • docker-up: Fixed port conflict by removing unnecessary start-pmtiles-server dependency
• CI (.github/workflows/ci.yml): Updated all cargo test commands for martin and martin-core packages to use --features test-pg

4. Documentation

• Updated docs/src/development.md with comprehensive testing section explaining:
  • How to run tests without PostgreSQL: cargo test
  • How to run ALL tests with PostgreSQL: just test
  • How to run ONLY PostgreSQL tests: just test-pg
  • How to run tests with PostgreSQL using cargo: cargo test --features test-pg (requires DATABASE_URL env var)
  • Clarified that --features test-pg runs ALL tests (not just PG tests)
  • Package-specific testing examples
  • Improved formatting for better readability

Validation Results:

✅ Without test-pg feature (no PostgreSQL or Docker required):

• cargo test --package martin --lib → 53 tests pass (down from 55, confirming container tests are gated)
• cargo test --package martin-core --lib → 34 tests pass
• cargo test --workspace --lib → All non-PG tests pass
• PG integration tests show "running 0 tests" (correctly skipped)
• Container-based builder tests are skipped

✅ With test-pg feature (requires PostgreSQL):

• Tests compile successfully with --features test-pg --no-run
• just test (which starts PG) uses --features test-pg and runs ALL tests
• just test-pg starts PG and runs ONLY PostgreSQL-specific tests (integration + lib tests)
• CI explicitly enables --features test-pg with PostgreSQL running

✅ Non-PG tests unaffected:

• MBTiles tests continue to work
• PMTiles tests continue to work
• Styles, sprites, fonts tests continue to work

✅ Justfile syntax validated:

• Arguments properly passed as separate strings to avoid shell escaping issues
• test-pg recipe now runs only PG-specific tests
• Fixed port conflict in CI by removing start-pmtiles-server dependency from docker-up

Impact:

Before:

• cargo test required PostgreSQL AND Docker to be running (for testcontainers)
• Developers needed to set up Docker and start PG before testing
• No simple command to run just PostgreSQL tests
• CI had port conflicts due to unnecessary dependencies

After:

• cargo test works without any external dependencies (no PG, no Docker)
• Developers can test most of the codebase immediately
• CI maintains full test coverage with explicit --features test-pg
• just test-pg command runs ONLY PostgreSQL-specific tests (not all tests)
• CI port conflicts resolved

Files Changed:

• 2 Cargo.toml files (feature definitions)
• 6 test files (feature gates, including builder.rs)
• 1 justfile (test commands with proper arg passing + test-pg recipe + fixed docker-up)
• 1 CI workflow (explicit feature flags)
• 1 documentation file (clarified testing requirements + improved formatting)

This implementation follows Rust best practices for feature-gating tests and maintains backward compatibility while significantly improving the development experience.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Make all PG-requiring tests feature-gated</issue_title>
<issue_description>We need to simplify our testing process, and that means that cargo test should pass without any external dependencies, i.e. without requiring PG to be running, or some env var to be set.

I think PostgreSQL tests are the only complex ones, so lets mark them all as requiring some test-pg feature (name?). Note that cargo test --all-features should still include the postgreSQL tests, and thus require some connection string to be set. This will be done by CI, but will make development simpler.</issue_description>

Comments on the Issue (you are @copilot in this section)

@todtb I was running full tests (including w/ pg) locally while working on the srid 4326 issue. I can take a look here.

If I understand correctly we'll just need to identify different tests w/ dependencies (pg, aws, etc), add a feature tag outside the default set, and modify the justfile commands accordingly? Then as for CI/CD, I'd imagine I'll need help setting up any required envvars</comment_new>

• Fixes Make all PG-requiring tests feature-gated #1739

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull request overview

This PR introduces a dedicated test-pg feature to ensure PostgreSQL-dependent tests don’t run under a plain cargo test, reducing contributor friction while keeping PG coverage available when explicitly enabled (and in CI).

Changes:

• Added a test-pg feature to martin and martin-core and updated PG-related tests to gate on test-pg instead of postgres.
• Updated just commands and CI invocations to run the PostgreSQL test suite by explicitly enabling --features test-pg.
• Documented the intended testing workflow in the development guide.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
martin/tests/utils.rs	Gates PG-only helpers/imports behind test-pg to avoid compiling PG helpers in non-PG test runs.
martin/tests/pg_table_source_test.rs	Switches PG integration test gating from postgres to test-pg.
martin/tests/pg_server_test.rs	Switches PG integration test gating from postgres to test-pg.
martin/tests/pg_function_source_test.rs	Switches PG integration test gating from postgres to test-pg.
martin/Cargo.toml	Adds test-pg feature as a test-only gate (enables postgres).
martin-core/src/tiles/postgres/pool.rs	Gates container-based unit tests on test-pg to prevent DB/Docker requirements in default test runs.
martin-core/Cargo.toml	Adds test-pg feature as a test-only gate (enables postgres).
justfile	Updates commands that start PostgreSQL to run tests with --features test-pg.
docs/src/development.md	Adds a Testing section explaining default vs PG-enabled test runs.
.github/workflows/ci.yml	Ensures CI runs PG-dependent tests by explicitly enabling --features test-pg.

[CommanderStorm]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

All changes from the review thread have been applied in commit 7ae0f09:

• Fixed justfile argument passing (separate quoted strings)
• Clarified documentation about DATABASE_URL requirement
• Gated container-based tests in builder.rs with test-pg feature

[CommanderStorm]

@copilot
this will run all the tests AND the postgres requring ones.
Please make this run only the PG-specific ones.

Also make sure that the rest of the justfile does not have test-cargo "--all-targets" "--features" "test-pg" sprinkeled in.

[Copilot]

Fixed in b9e39b0 - just test-pg now runs only PostgreSQL-specific tests (the 3 integration test files + lib tests for martin and martin-core packages that contain PG-gated unit tests).

The other uses of test-cargo with test-pg in the justfile (test, test-legacy, test-ssl, coverage) are intentional - these recipes are designed to run the full test suite with PostgreSQL enabled, not just PG-specific tests.

[nyurik]

seems reasonable

[CommanderStorm]

Suggested change

	just test # runs all tests
	just test-pg # starts PostgreSQL and runs only PostgreSQL-requiring tests
	```
	The `test-pg` feature gates tests that require a live PostgreSQL connection. This allows developers to run most tests locally without setting up PostgreSQL, while CI and integration testing can enable these tests explicitly.
	just test # runs all tests
	just test-pg # starts PostgreSQL and runs only PostgreSQL-requiring tests

The test-pg feature gates tests that require a live PostgreSQL connection.
This allows developers to run most tests locally without setting up PostgreSQL, while CI and integration testing can enable these tests explicitly.

[Copilot]

Applied in 0d7ebcb - improved documentation formatting for better readability.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.