chore: More restrictive expects#2562
Merged
CommanderStorm merged 7 commits intomaplibre:mainfrom Feb 14, 2026
Merged
Conversation
CommanderStorm
requested review from
Copilot and
nyurik
and removed request for
Copilot
nyurik
approved these changes
Feb 13, 2026
Merged
CommanderStorm
added a commit
that referenced
this pull request
Mar 15, 2026
## 🤖 New release * `martin-tile-utils`: 0.6.10 -> 0.6.11 (✓ API compatible changes) * `mbtiles`: 0.15.2 -> 0.15.3 (✓ API compatible changes) * `martin-core`: 0.3.0 -> 0.3.1 (✓ API compatible changes) * `martin`: 1.3.1 -> 1.4.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `mbtiles` <blockquote> ## [0.15.3](mbtiles-v0.15.2...mbtiles-v0.15.3) - 2026-03-14 ### Added - *(srv)* resolve some compression TODOS ([#2597](#2597)) ### Fixed - Accept any INT-containing type in MBTiles validation to be an integer ([#2560](#2560)) ### Other - rename the `webp.sql` fixture to `webp-no-primary.sql` ([#2564](#2564)) - More restrictive expects ([#2562](#2562)) </blockquote> ## `martin-core` <blockquote> ## [0.3.1](martin-core-v0.3.0...martin-core-v0.3.1) - 2026-03-14 ### Added - Add retry mechanism on locked/busy mbtiles files ([#2572](#2572)) ### Other - More restrictive expects ([#2562](#2562)) - feature-gate PostgreSQL tests to remove external dependencies from `cargo test` ([#2558](#2558)) </blockquote> ## `martin` <blockquote> ## [1.4.0](martin-v1.3.1...martin-v1.4.0) - 2026-03-14 ### Added - *(srv)* resolve some compression TODOS ([#2597](#2597)) - Migrate mdbooks to zensical ([#2576](#2576)) - *(martin-cp)* indicativ based progress bar ([#2495](#2495)) - Add retry mechanism on locked/busy mbtiles files ([#2572](#2572)) ### Fixed - *(ui)* render MLT tiles correctly in Tile Inspector ([#2601](#2601)) - redirect ignoring `--route-prefix` for .pbf tile requests ([#2599](#2599)) - restrict zooming and panning on data inspector ([#2574](#2574)) - Accept any INT-containing type in MBTiles validation to be an integer ([#2560](#2560)) ### Other - *(deps)* Bump the all-npm-version-updates group across 2 directories with 9 updates ([#2608](#2608)) - *(deps-dev)* Bump undici from 7.21.0 to 7.24.1 in /martin/martin-ui in the all-npm-security-updates group across 1 directory ([#2602](#2602)) - *(deps)* autoupdate pre-commit ([#2592](#2592)) - *(deps)* Bump the all-npm-version-updates group across 2 directories with 13 updates ([#2577](#2577)) - *(deps)* Bump the all-npm-security-updates group across 2 directories with 1 update ([#2575](#2575)) - *(deps)* autoupdate pre-commit ([#2567](#2567)) - rename the `webp.sql` fixture to `webp-no-primary.sql` ([#2564](#2564)) - more cfg magic instead of #[allow(unused_variables)] ([#2563](#2563)) - More restrictive expects ([#2562](#2562)) - feature-gate PostgreSQL tests to remove external dependencies from `cargo test` ([#2558](#2558)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves more of the
allow(..)s in our code and replaces them withexpect(..)or removes them.Reasons were added where apparent and cfg_attrs were added where absolutely nessesary.
I also enabled
clippy::as_underscorebecause it seemed like a nice thing to enable, but did not provide any occurance. Not sure why this is a restriction, it is fairly bug-prown to do this.