test: feature-gate PostgreSQL tests to remove external dependencies from cargo test

.github/workflows/ci.yml

@@ -80,6 +80,8 @@ jobs:
       - name: Checkout sources
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with: { persist-credentials: false }
+      - uses: taiki-e/install-action@763e3324d4fd026c9bd284c504378585777a87d5 # v2.62.57
+        with: { tool: 'just' }
       - name: Init database
         run: tests/fixtures/initdb.sh
         env:
@@ -92,6 +94,7 @@ jobs:
           cargo test --package mbtiles
           cargo test --package martin
           cargo test --package martin-core
+          just test-pg
         env:
           DATABASE_URL: postgres://${{ env.PGUSER }}:${{ env.PGUSER }}@${{ env.PGHOST }}:${{ job.services.postgres.ports[5432] }}/${{ env.PGDATABASE }}?sslmode=require
           AWS_SKIP_CREDENTIALS: 1
@@ -738,6 +741,7 @@ jobs:
           echo "$DATABASE_URL" | base64
           set -x
           cargo test --package martin
+          just test-pg
           cargo clean
         env:
           DATABASE_URL: postgres://${{ env.PGUSER }}:${{ env.PGUSER }}@${{ env.PGHOST }}:${{ job.services.postgres.ports[5432] }}/${{ env.PGDATABASE }}?sslmode=${{ matrix.sslmode }}

docs/src/development.md

@@ -143,6 +143,21 @@
 just stop        # stop test database
 ```
 
+### Testing
+
+Martin's test suite includes tests that require PostgreSQL to be running and tests that don't.
+
+```bash
+# Run tests that don't require PostgreSQL (no external dependencies)
+just test-cargo
+
+# Run all tests including PostgreSQL tests (requires PostgreSQL running)
+just test                                 # runs all tests
+just test-pg                              # starts PostgreSQL and runs only PostgreSQL-requiring tests
+```
+
+The `test-pg` feature gates tests that require a live PostgreSQL connection. This allows developers to run most tests locally without setting up PostgreSQL, while CI and integration testing can enable these tests explicitly.
+
 ### Pass arguments to commands
 
 ```bash

justfile

@@ -187,6 +187,7 @@ coverage *args='--no-clean --open':  (cargo-install 'cargo-llvm-cov') clean star
 
     echo "::group::Unit tests"
     {{just}} test-cargo --all-targets
+    {{just}} test-pg
     echo "::endgroup::"
 
     # echo "::group::Documentation tests"
@@ -383,7 +384,13 @@ shear:
     # https://github.com/Boshen/cargo-shear/pull/386
 
 # Run all tests using a test database
-test: start (test-cargo '--all-targets') test-doc test-frontend test-int
+test: start (test-cargo "--all-targets") test-pg test-doc test-frontend test-int
+
+# Run PostgreSQL-requiring tests only
+test-pg: start
+    cargo test --features test-pg --test pg_function_source_test --test pg_server_test --test pg_table_source_test
+    cargo test --features test-pg --package martin --lib
+    cargo test --features test-pg --package martin-core --lib
 
 # Run Rust unit tests (cargo test)
 test-cargo *args:
@@ -473,10 +480,10 @@ test-lambda martin_bin='target/debug/martin':
 
 
 # Run all tests using the oldest supported version of the database
-test-legacy: start-legacy (test-cargo '--all-targets') test-doc test-int
+test-legacy: start-legacy (test-cargo "--all-targets") test-pg test-doc test-int
 
 # Run all tests using an SSL connection to a test database. Expected output won't match.
-test-ssl: start-ssl (test-cargo '--all-targets') test-doc clean-test
+test-ssl: start-ssl (test-cargo "--all-targets") test-pg test-doc clean-test
     tests/test.sh
 
 # Run all tests using an SSL connection with client cert to a test database. Expected output won't match.

martin-core/Cargo.toml

@@ -60,6 +60,7 @@ styles = ["tokio/fs", "dep:dashmap"]
 mbtiles = ["dep:mbtiles", "_tiles"]
 pmtiles = ["dep:pmtiles", "dep:object_store", "_tiles"]
 _tiles = ["dep:base64"]
+test-pg = ["postgres"]
 
 [target.'cfg(target_os = "linux")'.dependencies]
 image = { workspace = true, optional = true }

martin-core/src/tiles/postgres/pool.rs

@@ -219,7 +219,7 @@ SELECT (regexp_matches(
     Ok(version)
 }
 
-#[cfg(test)]
+#[cfg(all(test, feature = "test-pg"))]
 mod tests {
     use deadpool_postgres::tokio_postgres::Config;
     use postgres::NoTls;

martin/Cargo.toml

@@ -117,6 +117,7 @@ sprites = ["martin-core/sprites"]
 styles = ["martin-core/styles", "dep:walkdir"]
 webui = ["dep:actix-web-static-files", "dep:static-files", "dep:walkdir"]
 _tiles = ["martin-core/_tiles"]
+test-pg = ["postgres"]
 
 [dependencies]
 actix-cors.workspace = true

martin/src/config/file/tiles/postgres/builder.rs

@@ -599,7 +599,7 @@ fn by_key<T>(a: &(String, T), b: &(String, T)) -> Ordering {
     a.0.cmp(&b.0)
 }
 
-#[cfg(test)]
+#[cfg(all(test, feature = "test-pg"))]
 mod tests {
     use indoc::indoc;
     use insta::assert_yaml_snapshot;

martin/tests/pg_function_source_test.rs

@@ -1,4 +1,4 @@
-#![cfg(feature = "postgres")]
+#![cfg(feature = "test-pg")]
 
 use indoc::indoc;
 use insta::assert_yaml_snapshot;

martin/tests/pg_server_test.rs

@@ -1,4 +1,4 @@
-#![cfg(feature = "postgres")]
+#![cfg(feature = "test-pg")]
 
 use actix_http::Request;
 use actix_web::http::StatusCode;

martin/tests/pg_table_source_test.rs

@@ -1,4 +1,4 @@
-#![cfg(feature = "postgres")]
+#![cfg(feature = "test-pg")]
 
 use indoc::indoc;
 use insta::assert_yaml_snapshot;

martin/tests/utils.rs

@@ -4,7 +4,7 @@ use std::env;
 
 use actix_web::dev::ServiceResponse;
 use actix_web::test::read_body;
-#[cfg(feature = "postgres")]
+#[cfg(feature = "test-pg")]
 use martin::config::file::postgres::TableInfo;
 use martin::config::file::{Config, ServerState};
 use martin::config::primitives::env::FauxEnv;
@@ -56,7 +56,7 @@ pub fn source(mock: &MockSource, name: &str) -> BoxedSource {
     sources.tiles.get_source(name).expect("source can be found")
 }
 
-#[cfg(feature = "postgres")]
+#[cfg(feature = "test-pg")]
 #[must_use]
 pub fn mock_pgcfg(yaml: &str) -> Config {
     mock_cfg(&indoc::formatdoc! {"
@@ -65,7 +65,7 @@ pub fn mock_pgcfg(yaml: &str) -> Config {
     ", yaml.replace('\n', "\n  ")})
 }
 
-#[cfg(feature = "postgres")]
+#[cfg(feature = "test-pg")]
 #[must_use]
 pub fn table<'a>(mock: &'a MockSource, name: &str) -> &'a TableInfo {
     let (_, config) = mock;