respect customer args #134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/Net/Stripe.pm
Outdated
Comment on lines
207
to
208
| $customer = $self->post_customer( %$customer ); | ||
| $customer_id = $customer->id; |
There was a problem hiding this comment.
I always worry when I see a subroutine's parameters being modified - $customer in this case.
How about this?
my $customer_obj = $self->post_customer( %$customer );
$customer_id = $customer_obj->id;
|
i am quite happy with that, and i wish i had come up with it. :-) as you will see, in this and other upcoming PRs, i am quite keen to move away from an idiom that is used quite frequently in the current codebase. which the code you reference is mostly a copy of. |
* use non-destructive idiom
Closed
This was referenced Jan 15, 2020
|
fixed in #147 by removing unsupported argument types |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #94