Merge pull request #133 from sherrardb/f-cannot-update-existing-card

allow updates to existing cards

Author: sherrardb

lib/Net/Stripe.pm

@@ -102,6 +102,18 @@ a card object. We have also added TypeConstraints for the string arguments
 passed and added in-method validation to ensure that the passed argument
 values make sense in the context of one another.
 
+=item add update_card()
+This method allows updates to card address, expiration, metadata, etc for
+existing customer cards.
+
+=item encode card metdata in convert_to_form_fields()
+
+When passing a hashref with a nested metadata hashref to _post(), that
+metadata must be encoded properly before being passed to the Stripe API.
+There is now a dedicated block in convert_to_form_fields for this operation.
+This update was necessary because of the addition of update_card(), which
+accepts a card hashref, which may include metadata.
+
 =back
 
 =method new PARAMHASH
@@ -576,6 +588,35 @@ Returns a L<Net::Stripe::Card>.
 
   $stripe->create_card(customer => $customer, card => $card);
 
+=card_method update_card
+
+Update a card.
+
+L<https://stripe.com/docs/api/cards/update#update_card>
+
+=over
+
+=item * customer_id - L<StripeCustomerId>
+
+=item * card_id - L<StripeCardId>
+
+=item * card - HashRef
+
+=back
+
+Returns a L<Net::Stripe::Card>.
+
+  $stripe->update_card(
+      customer_id => $customer_id,
+      card_id => $card_id,
+      card => {
+          name => $new_name,
+          metadata => {
+              'account-number' => $new_account_nunmber,
+          },
+      },
+  );
+
 =card_method get_cards
 
 Returns a list of cards.
@@ -668,6 +709,12 @@ Cards: {
         return $self->_post("customers/$customer/cards", $card);
     }
 
+    method update_card(StripeCustomerId :$customer_id!,
+                     StripeCardId :$card_id!,
+                     HashRef :$card!) {
+        return $self->_post("customers/$customer_id/cards/$card_id", $card);
+    }
+
     method delete_card(Net::Stripe::Customer|Str :$customer, Net::Stripe::Card|Str :$card) {
       if (ref($customer)) {
           $customer = $customer->id;
@@ -1595,6 +1642,10 @@ sub convert_to_form_fields {
                 foreach my $fn (keys %fields) {
                     $r->{$fn} = $fields{$fn};
                 }
+            } elsif ($key eq 'metadata' && ref($hash->{$key}) eq 'HASH') {
+                foreach my $fn (keys %{$hash->{$key}}) {
+                    $r->{$key . '[' . $fn . ']'} = $hash->{$key}->{$fn};
+                }
             } else {
                 $r->{$key} = $hash->{$key};
             }

lib/Net/Stripe/Card.pm

@@ -16,7 +16,7 @@ has 'address_zip'     => (is => 'ro', isa => 'Maybe[Str]');
 has 'address_city'    => (is => 'ro', isa => 'Maybe[Str]');
 has 'address_state'   => (is => 'ro', isa => 'Maybe[Str]');
 has 'address_country' => (is => 'ro', isa => 'Maybe[Str]');
-has 'metadata'        => (is => 'rw', isa => 'Maybe[HashRef]');
+has 'metadata'        => (is => 'ro', isa => 'Maybe[HashRef]');
 
 # Both input and output
 has 'exp_month'       => (is => 'ro', isa => 'Maybe[Int]', required => 1);

t/live.t

@@ -680,6 +680,66 @@ Customers: {
 
         }
 
+        Update_existing_card_for_customer_id: {
+            my $token = $stripe->post_token(card => $fake_card);
+            my $customer = $stripe->post_customer(
+                card => $token->id,
+            );
+            isa_ok $customer, 'Net::Stripe::Customer', 'got back a customer';
+            my $cards = $stripe->get_cards(
+                customer => $customer->id,
+            );
+            isa_ok $cards, 'Net::Stripe::List', 'Card List object returned';
+            is scalar @{$cards->data}, 1, 'customer only has one card';
+
+            my $card = @{$cards->data}[0];
+            isa_ok $card, 'Net::Stripe::Card';
+
+            is $card->id, $token->card->id, 'card token id matches';
+
+            for my $f (sort grep { $_ ne 'cvc' && $_ ne 'number' && $_ ne 'metadata' } keys %{$fake_card}) {
+                is $card->$f, $fake_card->{$f}, "card $f matches";
+            }
+            my $card_id = $card->id;
+
+            my $future_future = $future + DateTime::Duration->new(years => 1);
+            my $updated_fake_card = {
+                name            => 'Dr. Anonymous',
+                address_line1   => '321 Easy Street',
+                address_city    => 'Beverly Hills',
+                address_state   => 'California',
+                address_zip     => '90210',
+                address_country => 'United States',
+                exp_month       => $future_future->month,
+                exp_year        => $future_future->year,
+                metadata  => {
+                    'somenewcardmetadata' => 'can you hear me now?',
+                },
+            };
+
+            $stripe->update_card(
+                customer_id => $customer->id,
+                card_id => $card->id,
+                card => $updated_fake_card,
+            );
+
+            $cards = $stripe->get_cards(
+                customer => $customer->id,
+            );
+            isa_ok $cards, 'Net::Stripe::List', 'Card List object returned';
+            is scalar @{$cards->data}, 1, 'customer still only has one card';
+
+            $card = @{$cards->data}[0];
+            is $card->id, $card_id, "card id still matches";
+
+            for my $f (sort grep { $_ ne 'metadata' } keys %{$updated_fake_card}) {
+                is $card->$f, $updated_fake_card->{$f}, "updated card $f matches";
+            }
+            for my $k (sort keys %{$updated_fake_card->{metadata}}) {
+                is $card->metadata->{$k}, $updated_fake_card->{metadata}->{$k}, "updated card metadata $k matches";
+            }
+        }
+
         Customers_with_plans: {
             my $freeplan = $stripe->post_plan(
                 id => "free-$future_ymdhms",