Skip to content

fix post_charge() arguments #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2020
Merged

fix post_charge() arguments #147

merged 1 commit into from
Jan 18, 2020

Conversation

sherrardb
Copy link
Collaborator

@sherrardb sherrardb commented Jan 18, 2020 •
edited
Loading

@sherrardb
fix post_charge() arguments:
fd8e79e 
 * updated Kavorka signature to remove non-functional argument types
 * removed Net::Stripe::Customer and HashRef for customer, as neither form was being serialized correctly for passing to the API call
 * removed Net::Stripe::Card and Net::Stripe::Token for card, as neither form was being serialized correctly for passing to the API call
 * added in-method validation and unit tests for the different combinations of the allowed argument types
 * updated and reorganized failing unit tests
 * closes <lukec#94> and <lukec#137>
@sherrardb sherrardb force-pushed the fix-post-charge-args branch from 1ac1f5c to fd8e79e Compare January 18, 2020 19:44
@sherrardb sherrardb merged commit 646861d into lukec:master Jan 18, 2020
@sherrardb sherrardb deleted the fix-post-charge-args branch January 18, 2020 19:50
@sherrardb sherrardb mentioned this pull request Jan 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

post_charge() accepts Net::Stripe::Customer but Net::Stripe::Charge doesn't.
1 participant
@sherrardb