Skip to content

Fix AWS OIDC settings#953

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
PatrickXYS:test
Feb 26, 2020
Merged

Fix AWS OIDC settings#953
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
PatrickXYS:test

Conversation

@PatrickXYS

@PatrickXYS PatrickXYS commented Feb 26, 2020

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
Resolves #945

Description of your changes:
Since we have the issues like:

time="2020-02-23T06:33:18Z" level=error msg="Email doesn't exist in user's claim map[exp:1.582439718e+09 iss:https://kubeflow.auth0.com/ sub:github|4739316]. This is not supported"
time="2020-02-23T06:33:18Z" level=error msg="Email doesn't exist in user's claim map[exp:1.582439718e+09 iss:https://kubeflow.auth0.com/ sub:github|4739316]. This is not supported"

We need to add auth scope to override default setting, which is:

 alb.ingress.kubernetes.io/auth-scope: 'openid email profile'

Modified ingress.yaml, kustomize.yaml, and params.env files to fulfill the functionality.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

This change is Reviewable

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @PatrickXYS. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickXYS

Copy link
Copy Markdown
Member Author

/assign @Jeffwan

@Jeffwan

Jeffwan commented Feb 26, 2020

Copy link
Copy Markdown
Member

Can you update cognito example as well?

email	openid	aws.cognito.signin.user.admin	profile

@Jeffwan

Jeffwan commented Feb 26, 2020

Copy link
Copy Markdown
Member

Seems it's hard to convert email openid profile env to configmap values. Just use simple solution here.

@Jeffwan

Jeffwan commented Feb 26, 2020

Copy link
Copy Markdown
Member

/ok-to-test
/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5f457fd into kubeflow:master Feb 26, 2020
Jeffwan added a commit to Jeffwan/manifests that referenced this pull request Feb 28, 2020
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2020
…961)

* Create overlay allowing the Load Balancer to be created with HTTPS with it handling no auth. Additionally making the scheme (internet facing/internal) configurable and adding external-dns annotation for clusters with it installed. Cleaned up some duplicated annotations as well (#653)

* Upgrade aws component version (#890)

* Upgrade aws components versions for v1.0

* Update tests for aws components

* Add policy profile controller plugin need (#917)

* Add external mysql option for pipeline and metadata (#906)

* Add OWNERS file under test folder (#947)

* Fixing loadBalancerScheme issue in ingress annotation (#952)

* Fix AWS OIDC settings (#953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS OIDC setting can not get email in user claim

4 participants