Fix AWS OIDC settings#953
Conversation
|
Hi @PatrickXYS. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @Jeffwan |
|
Can you update cognito example as well? |
|
Seems it's hard to convert |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…961) * Create overlay allowing the Load Balancer to be created with HTTPS with it handling no auth. Additionally making the scheme (internet facing/internal) configurable and adding external-dns annotation for clusters with it installed. Cleaned up some duplicated annotations as well (#653) * Upgrade aws component version (#890) * Upgrade aws components versions for v1.0 * Update tests for aws components * Add policy profile controller plugin need (#917) * Add external mysql option for pipeline and metadata (#906) * Add OWNERS file under test folder (#947) * Fixing loadBalancerScheme issue in ingress annotation (#952) * Fix AWS OIDC settings (#953)
Which issue is resolved by this Pull Request:
Resolves #945
Description of your changes:
Since we have the issues like:
We need to add auth scope to override default setting, which is:
Modified
ingress.yaml,kustomize.yaml, andparams.envfiles to fulfill the functionality.Checklist:
cd manifests/testsmake generate-changed-onlymake testThis change is