Skip to content

Upgrade aws component version#890

Merged
k8s-ci-robot merged 2 commits into
kubeflow:masterfrom
Jeffwan:upgrade_aws_component_version
Feb 12, 2020
Merged

Upgrade aws component version#890
k8s-ci-robot merged 2 commits into
kubeflow:masterfrom
Jeffwan:upgrade_aws_component_version

Conversation

@Jeffwan

@Jeffwan Jeffwan commented Feb 10, 2020

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
Resolves #889

Description of your changes:

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

This change is Reviewable

@jlewi

jlewi commented Feb 12, 2020

Copy link
Copy Markdown
Contributor

/lgtm
/approve

/hold

@Jeffwan Since this only impacts AWS I did a drive by LGTM; if you want a more thorough review maybe someone with AWS expertise can help out; otherwise just remove the hold

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan

Jeffwan commented Feb 12, 2020

Copy link
Copy Markdown
Member Author

/hold cancel

@jlewi

jlewi commented Feb 12, 2020

Copy link
Copy Markdown
Contributor

Test failures look like: kubeflow/testing/issues/607

@jlewi

jlewi commented Feb 12, 2020

Copy link
Copy Markdown
Contributor

/test all

@k8s-ci-robot k8s-ci-robot merged commit 907d9dc into kubeflow:master Feb 12, 2020
@Jeffwan Jeffwan deleted the upgrade_aws_component_version branch February 12, 2020 18:41
Jeffwan added a commit to Jeffwan/manifests that referenced this pull request Feb 28, 2020
* Upgrade aws components versions for v1.0

* Update tests for aws components
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2020
…961)

* Create overlay allowing the Load Balancer to be created with HTTPS with it handling no auth. Additionally making the scheme (internet facing/internal) configurable and adding external-dns annotation for clusters with it installed. Cleaned up some duplicated annotations as well (#653)

* Upgrade aws component version (#890)

* Upgrade aws components versions for v1.0

* Update tests for aws components

* Add policy profile controller plugin need (#917)

* Add external mysql option for pipeline and metadata (#906)

* Add OWNERS file under test folder (#947)

* Fixing loadBalancerScheme issue in ingress annotation (#952)

* Fix AWS OIDC settings (#953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade AWS component versions for 1.0 - ALB Ingress, CSI plugin, device plugin, cluster version

4 participants