Skip to content

fix yamllint workflow and refresh versions#3423

Merged
google-oss-prow[bot] merged 4 commits into
kubeflow:unify-yamllintfrom
danish9039:unify-yamllint-followup
Mar 26, 2026
Merged

fix yamllint workflow and refresh versions#3423
google-oss-prow[bot] merged 4 commits into
kubeflow:unify-yamllintfrom
danish9039:unify-yamllint-followup

Conversation

@danish9039

@danish9039 danish9039 commented Mar 25, 2026

Copy link
Copy Markdown
Member

This follow-up continues the work from #3418 on top of kubeflow/unify-yamllint, as requested.

The branch had one failing GitHub Actions job, format_YAML_files, but the failure was not caused by a YAML formatting violation in the repository. The workflow step that prints the YAML formatting guidance had an unterminated quoted echo block, so the job failed in the shell before yamllint ran. The same branch also had two related regressions in the linting setup: the YAML changed-file filter had been rewritten into a form that cannot match git diff --name-only output, and the top-level exclude value in .pre-commit-config.yaml used an invalid Python regular expression.

This PR fixes that workflow regression and completes the requested version refresh in the same area. It pins the workflow-installed yamllint version to 1.38.0, updates the pre-commit hook versions for yamllint, black, and shellcheck-py, replaces the invalid top-level pre-commit exclusion with a valid regex, and restores a working YAML changed-file filter while keeping the explicit --config-file .yamllint.yaml behavior.

Verification:

  • pre-commit run --files .pre-commit-config.yaml .github/workflows/linting_bash_python_yaml_files.yaml .yamllint.yaml
  • local bash -n validation of the extracted YAML Formatting Guidelines shell snippet

Copilot AI review requested due to automatic review settings March 25, 2026 11:54
@github-actions

Copy link
Copy Markdown

Welcome to the Kubeflow Manifests Repository

Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community.

Before making more PRs:
Please ensure your PR follows our Contributing Guide.
Please also be aware that many components are synchronizes from upstream via the scripts in /scripts.
So in some cases you have to fix the problem in the upstream repositories first, but you can use a PR against kubeflow/manifests to test the platform integration.

Community Resources:

Thanks again for helping to improve Kubeflow.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the YAML linting automation and refreshes related lint tool versions to restore a passing, accurate format_YAML_files GitHub Actions job.

Changes:

  • Pin workflow-installed yamllint to 1.38.0 and fix the unterminated YAML-guidance echo block.
  • Restore a working “changed YAML files” selection pipeline for the workflow.
  • Refresh pre-commit hook versions and replace the invalid top-level pre-commit exclude with a valid regex.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.pre-commit-config.yaml Updates hook versions and fixes the repository-wide pre-commit exclusion regex.
.github/workflows/linting_bash_python_yaml_files.yaml Fixes the YAML lint workflow guidance block, pins yamllint, and repairs changed-file filtering.

Comment thread .github/workflows/linting_bash_python_yaml_files.yaml Outdated
Comment thread .github/workflows/linting_bash_python_yaml_files.yaml Outdated
@danish9039 danish9039 changed the title [codex] fix yamllint workflow and refresh versions fix yamllint workflow and refresh versions Mar 25, 2026
danish9039 and others added 2 commits March 25, 2026 17:38
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com>
@danish9039 danish9039 force-pushed the unify-yamllint-followup branch from 02d2092 to 3d0f02a Compare March 25, 2026 12:09
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Comment thread .github/workflows/linting_bash_python_yaml_files.yaml
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@juliusvonkohout

Copy link
Copy Markdown
Member

Thank you
/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit 0c74ba3 into kubeflow:unify-yamllint Mar 26, 2026
6 checks passed
google-oss-prow Bot pushed a commit that referenced this pull request Mar 26, 2026
* Refine .yamllint.yaml configuration settings

Updated .yamllint.yaml configuration options for clarity and consistency.

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update linting_bash_python_yaml_files.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update .pre-commit-config.yaml

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>

* fix yamllint workflow and refresh versions (#3423)

* test: refresh yamllint tooling

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

* Update .github/workflows/linting_bash_python_yaml_files.yaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com>

* test: install yamllint on PATH

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

* test: keep yamllint exclusions in config

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>

---------

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Fix pre-commit top-level exclude regex broken by YAML block scalar trailing newline (#3425)

* Initial plan

* Fix top-level exclude block scalar in .pre-commit-config.yaml

Co-authored-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Agent-Logs-Url: https://github.com/kubeflow/manifests/sessions/7bc9cd3a-d1b3-416a-be8b-19087f67c814

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: hippie-danish <133037056+danish9039@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants