Refine .yamllint.yaml configuration settings#3418
Merged
Merged
Conversation
Updated .yamllint.yaml configuration options for clarity and consistency. Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s yamllint configuration to refine linting behavior and expand ignored paths.
Changes:
- Disable the
document-startrule and adjust indentation and line-length settings. - Add an ignore pattern intended to exclude upstream content.
- Customize comment formatting rules.
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com>
Member
Author
|
Please also update all versions |
* test: refresh yamllint tooling Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> * Update .github/workflows/linting_bash_python_yaml_files.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com> * test: install yamllint on PATH Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> * test: keep yamllint exclusions in config Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> --------- Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/hold |
Contributor
|
@juliusvonkohout I've opened a new pull request, #3425, to work on those changes. Once the pull request is ready, I'll request review from you. |
…ailing newline (#3425) * Initial plan * Fix top-level exclude block scalar in .pre-commit-config.yaml Co-authored-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Agent-Logs-Url: https://github.com/kubeflow/manifests/sessions/7bc9cd3a-d1b3-416a-be8b-19087f67c814 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Member
Author
|
/unhold |
Member
Author
|
please someone /lgtm @tarekabouzeid |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@danish9039 to continue