fix yamllint workflow and refresh versions#3423
Conversation
|
Welcome to the Kubeflow Manifests Repository Thanks for opening your first PR. Your contribution means a lot to the Kubeflow community. Before making more PRs: Community Resources:
Thanks again for helping to improve Kubeflow. |
There was a problem hiding this comment.
Pull request overview
Fixes the YAML linting automation and refreshes related lint tool versions to restore a passing, accurate format_YAML_files GitHub Actions job.
Changes:
- Pin workflow-installed
yamllintto1.38.0and fix the unterminated YAML-guidanceechoblock. - Restore a working “changed YAML files” selection pipeline for the workflow.
- Refresh pre-commit hook versions and replace the invalid top-level pre-commit
excludewith a valid regex.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Updates hook versions and fixes the repository-wide pre-commit exclusion regex. |
.github/workflows/linting_bash_python_yaml_files.yaml |
Fixes the YAML lint workflow guidance block, pins yamllint, and repairs changed-file filtering. |
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com>
02d2092 to
3d0f02a
Compare
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
|
Thank you |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Refine .yamllint.yaml configuration settings Updated .yamllint.yaml configuration options for clarity and consistency. Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update linting_bash_python_yaml_files.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * Update .pre-commit-config.yaml Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> * fix yamllint workflow and refresh versions (#3423) * test: refresh yamllint tooling Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> * Update .github/workflows/linting_bash_python_yaml_files.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com> * test: install yamllint on PATH Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> * test: keep yamllint exclusions in config Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> --------- Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix pre-commit top-level exclude regex broken by YAML block scalar trailing newline (#3425) * Initial plan * Fix top-level exclude block scalar in .pre-commit-config.yaml Co-authored-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Agent-Logs-Url: https://github.com/kubeflow/manifests/sessions/7bc9cd3a-d1b3-416a-be8b-19087f67c814 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Julius von Kohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> Signed-off-by: hippie-danish <133037056+danish9039@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: hippie-danish <133037056+danish9039@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This follow-up continues the work from #3418 on top of
kubeflow/unify-yamllint, as requested.The branch had one failing GitHub Actions job,
format_YAML_files, but the failure was not caused by a YAML formatting violation in the repository. The workflow step that prints the YAML formatting guidance had an unterminated quotedechoblock, so the job failed in the shell beforeyamllintran. The same branch also had two related regressions in the linting setup: the YAML changed-file filter had been rewritten into a form that cannot matchgit diff --name-onlyoutput, and the top-levelexcludevalue in.pre-commit-config.yamlused an invalid Python regular expression.This PR fixes that workflow regression and completes the requested version refresh in the same area. It pins the workflow-installed
yamllintversion to1.38.0, updates the pre-commit hook versions foryamllint,black, andshellcheck-py, replaces the invalid top-level pre-commit exclusion with a valid regex, and restores a working YAML changed-file filter while keeping the explicit--config-file .yamllint.yamlbehavior.Verification:
pre-commit run --files .pre-commit-config.yaml .github/workflows/linting_bash_python_yaml_files.yaml .yamllint.yamlbash -nvalidation of the extractedYAML Formatting Guidelinesshell snippet