Skip to content

v1.1 manifests for vanilla k8s#1483

Merged
k8s-ci-robot merged 4 commits into
kubeflow:masterfrom
swiftdiaries:1-1-vanilla-k8s
Aug 18, 2020
Merged

v1.1 manifests for vanilla k8s#1483
k8s-ci-robot merged 4 commits into
kubeflow:masterfrom
swiftdiaries:1-1-vanilla-k8s

Conversation

@swiftdiaries

@swiftdiaries swiftdiaries commented Aug 12, 2020

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
Resolves
kubeflow/website#1984

Description of your changes:
Added v1.1 for vanilla k8s KFDef

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot

kubeflow-bot commented Aug 12, 2020

Copy link
Copy Markdown
Contributor

This change is Reviewable

@google-cla google-cla Bot added the cla: yes label Aug 12, 2020
@swiftdiaries swiftdiaries requested review from Jeffwan and removed request for krishnadurai August 12, 2020 02:25
@swiftdiaries swiftdiaries changed the base branch from master to v1.1-branch August 12, 2020 02:29
@swiftdiaries swiftdiaries changed the base branch from v1.1-branch to master August 12, 2020 02:29
@swiftdiaries swiftdiaries mentioned this pull request Aug 12, 2020
Merged
1 task
@PatrickXYS

PatrickXYS commented Aug 12, 2020

Copy link
Copy Markdown
Member

It would be great if we can adopt multi-tenancy KFP and V3 manifests solution into vanilla K8s manifests.

But I'm okay if we don't have enough capacity.

@swiftdiaries

swiftdiaries commented Aug 12, 2020

Copy link
Copy Markdown
Member Author

Hey @PatrickXYS
Thanks for the review. Let me take a look at it and if I can't get a commit in by tomorrow, we can probably go ahead and merge it

@swiftdiaries swiftdiaries mentioned this pull request Aug 12, 2020
Closed
5 tasks
@HassanOuda

HassanOuda commented Aug 13, 2020

Copy link
Copy Markdown

Hey @swiftdiaries , were you able to ad in multitenancy KFP into these vanilla k8s v1.1 manifests?

@swiftdiaries

swiftdiaries commented Aug 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Hey @HassanOuda
I'm looking to add the single-user KFDef and the related v3 kustomize stack first.
@krishnadurai will look to add the multi-user KFP and the related Istio-Dex KFDef and the v3 stack before Tuesday

@HassanOuda

HassanOuda commented Aug 13, 2020

Copy link
Copy Markdown

Perfect, thanks a lot @swiftdiaries

@swiftdiaries

swiftdiaries commented Aug 17, 2020

Copy link
Copy Markdown
Member Author

Hey @PatrickXYS
Could you please take another pass? I've scoped it down to single user KF

@PatrickXYS

PatrickXYS commented Aug 17, 2020

Copy link
Copy Markdown
Member

/lgtm

@swiftdiaries Thanks for contribution!

@PatrickXYS

PatrickXYS commented Aug 18, 2020

Copy link
Copy Markdown
Member

@swiftdiaries Can you /approve rather than approve from UI. The approve tag is missing thus can't automatic merge.

@swiftdiaries

swiftdiaries commented Aug 18, 2020

Copy link
Copy Markdown
Member Author

/approve

@k8s-ci-robot

k8s-ci-robot commented Aug 18, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swiftdiaries

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c429076 into kubeflow:master Aug 18, 2020
@swiftdiaries swiftdiaries deleted the 1-1-vanilla-k8s branch August 18, 2020 01:35
swiftdiaries added a commit to swiftdiaries/manifests that referenced this pull request Aug 18, 2020
@swiftdiaries
v1.1 manifests for vanilla k8s (kubeflow#1483)
f58a83b 
* v1.1 manifests for vanilla k8s

* adds k8s_istio v3 kfdef

* add tests

(cherry picked from commit c429076)
@swiftdiaries swiftdiaries restored the 1-1-vanilla-k8s branch August 18, 2020 23:23
swiftdiaries added a commit to swiftdiaries/manifests that referenced this pull request Aug 18, 2020
@swiftdiaries
v1.1 manifests for vanilla k8s (kubeflow#1483)
82ceb3d 
* v1.1 manifests for vanilla k8s

* adds k8s_istio v3 kfdef

* add tests

(cherry picked from commit c429076)
k8s-ci-robot pushed a commit that referenced this pull request Aug 19, 2020
@swiftdiaries
v1.1 manifests for vanilla k8s (#1484)
1f948ed 
* v1.1 istio dex components for kubernetes installation (#1494)

* v1.1 istio dex components for kubernetes installation

* Adds kfdef and creds correction

* Test cases generated

* v1.1.0 kfdef added

(cherry picked from commit 6dcebbe)

* v1.1 manifests for vanilla k8s (#1483)

* v1.1 manifests for vanilla k8s

* adds k8s_istio v3 kfdef

* add tests

(cherry picked from commit c429076)

* Fix tests

[Issue: kubeflow/kubeflow#5022]
[See also: kubeflow/website#1984]
@swiftdiaries swiftdiaries deleted the 1-1-vanilla-k8s branch September 2, 2020 20:42
@sakaia

sakaia commented Sep 11, 2020

Copy link
Copy Markdown

This manifest does not include seldon-core. Is this intentionally?

@swiftdiaries

swiftdiaries commented Sep 11, 2020

Copy link
Copy Markdown
Member Author

Totally wasn't intentional. It's a standalone installation that works well independently. Instructions: https://github.com/kubeflow/manifests/tree/master/seldon#install-seldon-operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PatrickXYS PatrickXYS Awaiting requested review from PatrickXYS

@krishnadurai krishnadurai Awaiting requested review from krishnadurai

1 more reviewer

@Jeffwan Jeffwan Jeffwan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PatrickXYS PatrickXYS

Labels

approved cla: yes lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@swiftdiaries @kubeflow-bot @PatrickXYS @HassanOuda @k8s-ci-robot @sakaia @Jeffwan