Skip to content

v1.1 istio dex components for kubernetes installation#1494

Merged
k8s-ci-robot merged 4 commits into
kubeflow:masterfrom
krishnadurai:feature/v1.1_istio_dex
Aug 17, 2020
Merged

v1.1 istio dex components for kubernetes installation#1494
k8s-ci-robot merged 4 commits into
kubeflow:masterfrom
krishnadurai:feature/v1.1_istio_dex

Conversation

@krishnadurai

@krishnadurai krishnadurai commented Aug 14, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@google-cla google-cla Bot added the cla: yes label Aug 14, 2020
@k8s-ci-robot

k8s-ci-robot commented Aug 14, 2020

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubeflow-bot

kubeflow-bot commented Aug 14, 2020

Copy link
Copy Markdown
Contributor

This change is Reviewable

@krishnadurai krishnadurai marked this pull request as ready for review August 14, 2020 18:22
@krishnadurai

krishnadurai commented Aug 14, 2020

Copy link
Copy Markdown
Contributor Author

/assign @swiftdiaries @PatrickXYS @yanniszark

PatrickXYS
PatrickXYS reviewed Aug 14, 2020
View reviewed changes
Comment thread kfdef/kfctl_istio_dex.yaml Outdated
Comment on lines +80 to +81
path: aws/istio-ingress/base_v3
name: istio-ingress

@PatrickXYS PatrickXYS Aug 14, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for vanilla k8s installation, it might be better to not use cloud provider binding manifests, including gcp/aws/ibm.

@krishnadurai krishnadurai Aug 14, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@PatrickXYS

PatrickXYS commented Aug 17, 2020

Copy link
Copy Markdown
Member

/lgtm

@swiftdiaries

swiftdiaries commented Aug 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

/lgtm
/approve
Thanks for the super quick response!

@swiftdiaries

swiftdiaries commented Aug 17, 2020

Copy link
Copy Markdown
Member

/approve

@k8s-ci-robot

k8s-ci-robot commented Aug 17, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swiftdiaries

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6dcebbe into kubeflow:master Aug 17, 2020
swiftdiaries pushed a commit to swiftdiaries/manifests that referenced this pull request Aug 18, 2020
@krishnadurai @swiftdiaries
v1.1 istio dex components for kubernetes installation (kubeflow#1494)
77c9d61 
* v1.1 istio dex components for kubernetes installation

* Adds kfdef and creds correction

* Test cases generated

* v1.1.0 kfdef added

(cherry picked from commit 6dcebbe)
@swiftdiaries swiftdiaries mentioned this pull request Aug 18, 2020
Merged
1 task
swiftdiaries added a commit to swiftdiaries/manifests that referenced this pull request Aug 18, 2020
@swiftdiaries
v1.1 istio dex components for kubernetes installation (kubeflow#1494)
5d219b1 
* v1.1 istio dex components for kubernetes installation

* Adds kfdef and creds correction

* Test cases generated

* v1.1.0 kfdef added

(cherry picked from commit 6dcebbe)
k8s-ci-robot pushed a commit that referenced this pull request Aug 19, 2020
@swiftdiaries
v1.1 manifests for vanilla k8s (#1484)
1f948ed 
* v1.1 istio dex components for kubernetes installation (#1494)

* v1.1 istio dex components for kubernetes installation

* Adds kfdef and creds correction

* Test cases generated

* v1.1.0 kfdef added

(cherry picked from commit 6dcebbe)

* v1.1 manifests for vanilla k8s (#1483)

* v1.1 manifests for vanilla k8s

* adds k8s_istio v3 kfdef

* add tests

(cherry picked from commit c429076)

* Fix tests

[Issue: kubeflow/kubeflow#5022]
[See also: kubeflow/website#1984]
@Bobgy Bobgy mentioned this pull request Aug 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bobgy Bobgy Awaiting requested review from Bobgy

@PatrickXYS PatrickXYS Awaiting requested review from PatrickXYS

Assignees

@yanniszark yanniszark

@swiftdiaries swiftdiaries

@PatrickXYS PatrickXYS

Labels

approved cla: yes lgtm size/XXL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@krishnadurai @k8s-ci-robot @kubeflow-bot @PatrickXYS @swiftdiaries @yanniszark