Skip to content

v1.1 manifests for vanilla k8s#1484

Merged
k8s-ci-robot merged 3 commits into
kubeflow:v1.1-branchfrom
swiftdiaries:1-1-cherry-pick
Aug 19, 2020
Merged

v1.1 manifests for vanilla k8s#1484
k8s-ci-robot merged 3 commits into
kubeflow:v1.1-branchfrom
swiftdiaries:1-1-cherry-pick

Conversation

@swiftdiaries

@swiftdiaries swiftdiaries commented Aug 12, 2020

Copy link
Copy Markdown
Member

Cherry-pick commits from PR #1494 #1483

Which issue is resolved by this Pull Request:
Resolves kubeflow/kubeflow#5022
Related: #1491

Description of your changes:
Adds v1.1 KFDef for vanilla k8s clusters

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot

Copy link
Copy Markdown
Contributor

This change is Reviewable

@swiftdiaries

Copy link
Copy Markdown
Member Author

Needs #1483 to merge first (?)

@PatrickXYS

Copy link
Copy Markdown
Member

Seems like unit test failed http://testing-argo.kubeflow.org/workflows/kubeflow-test-infra/kubeflow-manifests-presubmit-unit-1484-94770df-8176-f783?tab=workflow&nodeId=kubeflow-manifests-presubmit-unit-1484-94770df-8176-f783-3280408246.

Can you try make generate-changed-only to see what happened?

@swiftdiaries

Copy link
Copy Markdown
Member Author

@PatrickXYS I'm waiting on #1483 to go in before I cherry-pick those changes in this PR
Can I ping you when that's done for a review?

@google-cla

google-cla Bot commented Aug 18, 2020

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla Bot added cla: no and removed cla: yes labels Aug 18, 2020
@jlewi

jlewi commented Aug 18, 2020

Copy link
Copy Markdown
Contributor

Why are 705 files being changed? Are these just test files?

@swiftdiaries

Copy link
Copy Markdown
Member Author

Yes, they're all test files. It's adding a new stack called kubernetes so all test files related to that stack is generated here.
A comparable PR adding the AWS stack: #1419

@google-cla

google-cla Bot commented Aug 18, 2020

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@PatrickXYS

Copy link
Copy Markdown
Member

Hey @swiftdiaries when you cherry-pick others' commits, you need to re-write commit author to you. And make sure the author of all the commits to be you.

Otherwise, the CLA check failed.

CLAs are signed, but unable to verify author consent

@swiftdiaries

Copy link
Copy Markdown
Member Author

Ah thanks for the pointer @PatrickXYS
Let me update with that

* v1.1 istio dex components for kubernetes installation

* Adds kfdef and creds correction

* Test cases generated

* v1.1.0 kfdef added

(cherry picked from commit 6dcebbe)
* v1.1 manifests for vanilla k8s

* adds k8s_istio v3 kfdef

* add tests

(cherry picked from commit c429076)
@PatrickXYS

Copy link
Copy Markdown
Member

/lgtm

@swiftdiaries

Copy link
Copy Markdown
Member Author

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swiftdiaries

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants