v1.1 manifests for vanilla k8s#1484
Conversation
|
Needs #1483 to merge first (?) |
|
Seems like unit test failed http://testing-argo.kubeflow.org/workflows/kubeflow-test-infra/kubeflow-manifests-presubmit-unit-1484-94770df-8176-f783?tab=workflow&nodeId=kubeflow-manifests-presubmit-unit-1484-94770df-8176-f783-3280408246. Can you try |
|
@PatrickXYS I'm waiting on #1483 to go in before I cherry-pick those changes in this PR |
94770df to
5b15bf0
Compare
5b15bf0 to
f58a83b
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Why are 705 files being changed? Are these just test files? |
|
Yes, they're all test files. It's adding a new stack called |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
Hey @swiftdiaries when you cherry-pick others' commits, you need to re-write commit author to you. And make sure the author of all the commits to be you. Otherwise, the CLA check failed. |
|
Ah thanks for the pointer @PatrickXYS |
* v1.1 istio dex components for kubernetes installation * Adds kfdef and creds correction * Test cases generated * v1.1.0 kfdef added (cherry picked from commit 6dcebbe)
* v1.1 manifests for vanilla k8s * adds k8s_istio v3 kfdef * add tests (cherry picked from commit c429076)
[Issue: kubeflow/kubeflow#5022] [See also: kubeflow/website#1984]
40eaca2 to
33cfe5d
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swiftdiaries The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry-pick commits from PR #1494 #1483
Which issue is resolved by this Pull Request:
Resolves kubeflow/kubeflow#5022
Related: #1491
Description of your changes:
Adds v1.1 KFDef for vanilla k8s clusters
Checklist:
cd manifests/testsmake generate-changed-onlymake test