Skip to content

add kfctl_ibm_dex_multi_user.yaml kfdef configuration#1428

Merged
k8s-ci-robot merged 8 commits into
kubeflow:masterfrom
adrian555:multi-user
Jul 31, 2020
Merged

add kfctl_ibm_dex_multi_user.yaml kfdef configuration#1428
k8s-ci-robot merged 8 commits into
kubeflow:masterfrom
adrian555:multi-user

Conversation

@adrian555

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:

related to #1364

Description of your changes:

This PR introduces the multi-user version of kfdef configuration with dex running on IBM platform.
The multi-user version deploys kfp 1.0.0 with the pipeline/installs/multi-user kustomization.

The original kfctl_ibm.yaml kfdef is also upgraded to kfp 1.0.0 with the pipeline/installs/generic kustomization.

Checklist:

  • [ X ] Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot

Copy link
Copy Markdown
Contributor

This change is Reviewable

@adrian555

Copy link
Copy Markdown
Member Author

cc @animeshsingh @shawnzhu

@@ -0,0 +1,95 @@
apiVersion: kfdef.apps.kubeflow.org/v1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the release process now? Does vendor create v1.1.0 yaml by their own?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope the 1.1.0 version will be created when the v1.1.0 release is finally out. Since this multi-user may not make to v1.1.0 release, I will remove this version of kfdef.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrian555 multi-user should be part of v1.1.0 release

@shawnzhu

Copy link
Copy Markdown
Member

just FYI: I'm testing KFP multi-user on IKS by using this PR.

@animeshsingh

Copy link
Copy Markdown
Contributor

@shawnzhu are you ok with this PR in terms of multi-user pipelines testing?

@shawnzhu

Copy link
Copy Markdown
Member

@shawnzhu are you ok with this PR in terms of multi-user pipelines testing?

Yes! just need to document more how to use KFP multi-user.

@animeshsingh

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: animeshsingh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 759992c into kubeflow:master Jul 31, 2020
k8s-ci-robot pushed a commit that referenced this pull request Jul 31, 2020
…m_dex support #1355: add myself to kfdef/OWNERS #1428: add multi-user kfdef configurations Cherry pick of #1311 #1336 #1355 #1428 on v1.1-branch. #1311: KFServing Owners file #1336: kfctl_ibm_dex support #1355: add myself to kfdef/OWNERS #1428: add multi-user kfdef configurations (#1441)

* KFServing Owners file

* Update OWNERS

* knative owners

* Update OWNERS

* Update OWNERS

* Update OWNERS

* Update OWNERS

* Update OWNERS

* Update OWNERS

* kfctl_ibm_dex support

* add dex config

* fix

* update default config

* update dex-config.yaml

* add support for kustomize fns

* update docker image repo

* update oidc-authservice

* set default userid-header

* update tests

* add myself to kfdef/OWNERS

* add multi-user kfdef configurations

* replace env with envs

* update multi-user

* update with namespaces

* different ClusterRbacConfig for dex and non-dex

* add v1.1.0 ibm kfdef

* update generated tests

* update test expected data

Co-authored-by: Animesh Singh <singhan@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants