-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add kfctl_ibm_dex_multi_user.yaml kfdef configuration #1428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9ecada6
add multi-user kfdef configurations
adrian555 7110041
Merge remote-tracking branch 'upstream/master' into multi-user
adrian555 769f205
replace env with envs
adrian555 22003fc
update multi-user
adrian555 e601026
update with namespaces
adrian555 b21773f
different ClusterRbacConfig for dex and non-dex
adrian555 853897a
add v1.1.0 ibm kfdef
adrian555 066d8ba
update generated tests
adrian555 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| apiVersion: kfdef.apps.kubeflow.org/v1 | ||
| kind: KfDef | ||
| metadata: | ||
| namespace: kubeflow | ||
| spec: | ||
| applications: | ||
| # Install istio in a different namespace: istio-system | ||
| # Remove this application if istio is already installed | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/istio-stack | ||
| name: istio-stack | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/cluster-local-gateway | ||
| name: cluster-local-gateway | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/istio | ||
| name: istio | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/add-anonymous-user-filter | ||
| name: add-anonymous-user-filter | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: application/v3 | ||
| name: application | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/bootstrap | ||
| name: bootstrap | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/cert-manager-crds | ||
| name: cert-manager-crds | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/cert-manager-kube-system-resources | ||
| name: cert-manager-kube-system-resources | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/cert-manager | ||
| name: cert-manager | ||
| # Install Kubeflow applications. | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm | ||
| name: kubeflow-apps | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: metacontroller/base | ||
| name: metacontroller | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/spark-operator | ||
| name: spark-operator | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: knative/installs/generic | ||
| name: knative | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: kfserving/installs/generic | ||
| name: kfserving | ||
| # Spartakus is a separate applications so that kfctl can remove it | ||
| # to disable usage reporting | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/spartakus | ||
| name: spartakus | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/tensorboard | ||
| name: tensorboard | ||
| repos: | ||
| - name: manifests | ||
| uri: https://github.com/kubeflow/manifests/archive/v1.1.0.tar.gz | ||
| version: v1.1.0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| apiVersion: kfdef.apps.kubeflow.org/v1 | ||
| kind: KfDef | ||
| metadata: | ||
| namespace: kubeflow | ||
| spec: | ||
| applications: | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: namespaces/base | ||
| name: namespaces | ||
| # Install istio in a different namespace: istio-system | ||
| # Remove this application if istio is already installed | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/istio-1-3-1-stack | ||
| name: istio-stack | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/cluster-local-gateway-1-3-1 | ||
| name: cluster-local-gateway | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: istio/istio/base | ||
| name: istio | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: application/v3 | ||
| name: application | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/bootstrap | ||
| name: bootstrap | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/cert-manager-crds | ||
| name: cert-manager-crds | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/cert-manager-kube-system-resources | ||
| name: cert-manager-kube-system-resources | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/cert-manager | ||
| name: cert-manager | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/oidc-authservice | ||
| name: oidc-authservice | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/dex-auth | ||
| name: dex-auth | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: metacontroller/base | ||
| name: metacontroller | ||
| # Install kubeflow applications. | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/multi-user | ||
| name: kubeflow-apps | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/spark-operator | ||
| name: spark-operator | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: knative/installs/generic | ||
| name: knative | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: kfserving/installs/generic | ||
| name: kfserving | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/spartakus | ||
| name: spartakus | ||
| - kustomizeConfig: | ||
| repoRef: | ||
| name: manifests | ||
| path: stacks/ibm/application/tensorboard | ||
| name: tensorboard | ||
| repos: | ||
| - name: manifests | ||
| uri: https://github.com/kubeflow/manifests/archive/v1.1.0.tar.gz | ||
| version: v1.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| clusterDomain=cluster.local | ||
| userid-header=kubeflow-userid | ||
| userid-prefix= | ||
| cluster-name= | ||
| istio-namespace=istio-system |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| apiVersion: kustomize.config.k8s.io/v1beta1 | ||
| kind: Kustomization | ||
| namespace: kubeflow | ||
| resources: | ||
| - ../../../admission-webhook/webhook/v3 | ||
| - ../../../common/centraldashboard/overlays/stacks | ||
| - ../../../kubeflow-roles/base | ||
| - ../application/jupyter-web-app | ||
| - ../application/notebook-controller | ||
| - ../application/profiles | ||
| - ../../../pipeline/minio/installs/ibm | ||
| - ../../../pipeline/mysql/installs/ibm | ||
| - ../../../pipeline/installs/multi-user | ||
| - ../../../argo/base_v3 | ||
| - ../application/metadata | ||
| - ../../../pytorch-job/pytorch-job-crds/overlays/application | ||
| - ../../../pytorch-job/pytorch-operator/overlays/application | ||
| - ../../../tf-training/tf-job-crds/overlays/application | ||
| - ../../../tf-training/tf-job-operator/overlays/application | ||
| - ../../../katib/installs/katib-standalone-ibm | ||
| - ../../../seldon/seldon-core-operator/overlays/application | ||
| configMapGenerator: | ||
| - name: pipeline-mysql-parameters | ||
| behavior: merge | ||
| literals: | ||
| - mysqlPvcName=mysql-pv-claim | ||
| - name: pipeline-minio-parameters | ||
| behavior: merge | ||
| literals: | ||
| - minioPvcName=minio-pv-claim | ||
| - name: workflow-controller-parameters | ||
| behavior: merge | ||
| literals: | ||
| - containerRuntimeExecutor=pns | ||
| - name: profiles-config | ||
| behavior: merge | ||
| literals: | ||
| - admin=example@kubeflow.org | ||
| - name: kubeflow-config | ||
| envs: | ||
| - ./config/params.env | ||
| vars: | ||
| # We need to define vars at the top level otherwise we will get | ||
| # conflicts. | ||
| - fieldref: | ||
| fieldPath: data.clusterDomain | ||
| name: clusterDomain | ||
| objref: | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| name: kubeflow-config | ||
| - fieldref: | ||
| fieldPath: metadata.namespace | ||
| name: namespace | ||
| objref: | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| name: kubeflow-config | ||
| - fieldref: | ||
| fieldpath: metadata.namespace | ||
| name: katib-ui-namespace | ||
| objref: | ||
| kind: Service | ||
| name: katib-ui | ||
| apiVersion: v1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,5 +24,6 @@ rules: | |
| - "" | ||
| resources: | ||
| - secrets | ||
| - configmaps | ||
| verbs: | ||
| - get | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the release process now? Does vendor create v1.1.0 yaml by their own?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope the 1.1.0 version will be created when the v1.1.0 release is finally out. Since this multi-user may not make to v1.1.0 release, I will remove this version of kfdef.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrian555 multi-user should be part of v1.1.0 release