add kfctl_ibm_dex.yaml the dex version of Kubeflow kfdef configuration on IBM Cloud#1336
Conversation
|
This change is |
|
@shawnzhu also documents how to deploy using this kfdef configuration in kubeflow/website#2028. /cc @animeshsingh |
There was a problem hiding this comment.
/lgtm
@shawnzhu is this something you have tested on IBM Cloud?
@adrian555 the previous IBM Kustomizev3 PR which was merged -has that been cherrypicked to manifest 1.1. rc (or was it already there)?
cc @Tomcli
|
Additionally what are we testing? KFServing gives the most problems with auth/authz enabled environments - has anybody given that a spin? |
it was there before v1.1 branch was cut. |
Yes, I've tested from @adrian555 's branch on k8s v1.16 on IBM Cloud. |
|
Thanks @@adrian555, is it possible to add some documentation in a separate PR for the components we deploy in each stacks/ibm application? Right now those information are all hidden in each application's kustomization.yaml which make it difficult to debug and review. |
|
/lgtm Once merged, we should cherry pick this in manifests 1.1 branch @adrian555 |
|
/approve |
|
@Jeffwan @krishnadurai this is kfdef specific for IBM cloud platform, could you please approve? Thanks. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrian555, animeshsingh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…m_dex support #1355: add myself to kfdef/OWNERS #1428: add multi-user kfdef configurations Cherry pick of #1311 #1336 #1355 #1428 on v1.1-branch. #1311: KFServing Owners file #1336: kfctl_ibm_dex support #1355: add myself to kfdef/OWNERS #1428: add multi-user kfdef configurations (#1441) * KFServing Owners file * Update OWNERS * knative owners * Update OWNERS * Update OWNERS * Update OWNERS * Update OWNERS * Update OWNERS * Update OWNERS * kfctl_ibm_dex support * add dex config * fix * update default config * update dex-config.yaml * add support for kustomize fns * update docker image repo * update oidc-authservice * set default userid-header * update tests * add myself to kfdef/OWNERS * add multi-user kfdef configurations * replace env with envs * update multi-user * update with namespaces * different ClusterRbacConfig for dex and non-dex * add v1.1.0 ibm kfdef * update generated tests * update test expected data Co-authored-by: Animesh Singh <singhan@us.ibm.com>
7 participants
Which issue is resolved by this Pull Request:
Add a dex version of Kubeflow deployment on IBM Cloud.
Description of your changes:
Using GitHub OAuth application as authentication provider by dex, this PR adds a multi-tenant, auth-enabled configuration for Kubeflow deployment on IBM cloud.
Checklist:
cd manifests/testsmake generate-changed-onlymake testco-authored-by @shawnzhu and thanks @shawnzhu for testing.