Cherry pick #1396 #1410 to v1.1-branch#1419
Merged
Merged
Conversation
added 2 commits
July 24, 2020 12:50
* Migrate AWS manifest to v3 pattern * Clean up tests files * Add istio namespace to istio ingress * Update KFP pipeline test case for aws stack
* Changes needed for V3 change on AWS * Adopt AWS ECR image for jupyter-web-app components and generate all tests against manifest V3 changes * Adopt Cognito change against V3 * Adopt change for multi-user KFP
Contributor
|
This change is |
Member
Author
|
/cc @Jeffwan |
Member
Author
|
/test kubeflow-manifests-presubmit |
Member
|
Let's try to fix the test failure. |
Jeffwan
approved these changes
Jul 24, 2020
Member
|
/cc @jlewi @animeshsingh @yanniszark @hougangliu We'd like to cherry-pick v3 manifest with multi-user pipeline on AWS to 1.1. please help approve the change. |
k8s-ci-robot
requested review from
animeshsingh,
hougangliu,
jlewi and
yanniszark
Member
|
/lgtm |
Member
Author
|
/cc @terrytangyuan Can you take a look? |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
Description of your changes:
Cherry-pick kubeflow/manifests AWS changes to v1.1-branch for release purpose.
Checklist:
cd manifests/testsmake generate-changed-onlymake test