AWS Kfdef changes using v3 stacks #1410
Merged
Merged
Conversation
Contributor
|
This change is |
Member
Author
|
/assign @Jeffwan |
Jeffwan
changed the title
Jeffwan
reviewed
Jul 23, 2020
Member
|
@PatrickXYS Make sure you follow this process and generate test case for new manifest change
|
PatrickXYS
force-pushed
the
yao_aws_account
branch
from
3d62d5f to
b7a0ad3
Compare
…ests against manifest V3 changes
PatrickXYS
force-pushed
the
yao_aws_account
branch
from
b7a0ad3 to
55839f4
Compare
Jeffwan
reviewed
Jul 23, 2020
Jeffwan
reviewed
Jul 23, 2020
PatrickXYS
force-pushed
the
yao_aws_account
branch
6 times, most recently
from
c7e6fc4 to
b2b83f2
Compare
PatrickXYS
force-pushed
the
yao_aws_account
branch
from
b2b83f2 to
2ba3645
Compare
Contributor
|
/lgtm |
Member
Author
|
Quick update: I tested against v3 Dex / Cognito / Multi-user KFP, all succeeded without any issue. Will leave this open until we make decision to merge. Related kfctl PR: kubeflow/kfctl#380 |
PatrickXYS
force-pushed
the
yao_aws_account
branch
from
d63ed62 to
5fc06a1
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Member
|
Excellent work! @PatrickXYS |
PatrickXYS
pushed a commit
to PatrickXYS/manifests
that referenced
this pull request
Jul 24, 2020
* Changes needed for V3 change on AWS * Adopt AWS ECR image for jupyter-web-app components and generate all tests against manifest V3 changes * Adopt Cognito change against V3 * Adopt change for multi-user KFP
1 task
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jul 25, 2020
* Migrate AWS manifests to v3 pattern (#1396) * Migrate AWS manifest to v3 pattern * Clean up tests files * Add istio namespace to istio ingress * Update KFP pipeline test case for aws stack * AWS Kfdef changes using v3 stacks (#1410) * Changes needed for V3 change on AWS * Adopt AWS ECR image for jupyter-web-app components and generate all tests against manifest V3 changes * Adopt Cognito change against V3 * Adopt change for multi-user KFP * Update tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue is resolved by this Pull Request:
It helps AWS migrate to manifest V3.
Description of your changes:
kfctl_aws.yamlandkfctl_aws_congnito.yaml.stacks/aws/applicationdirectory for a work-around.jupyter-web-appcomponent.Checklist:
cd manifests/testsmake generate-changed-onlymake test