Skip to content

Update resources in pipeline-runner role#1060

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
Jeffwan:pipeline-runner-role
Apr 14, 2020
Merged

Update resources in pipeline-runner role#1060
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
Jeffwan:pipeline-runner-role

Conversation

@Jeffwan

@Jeffwan Jeffwan commented Mar 30, 2020

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
Sync permissions to manifest.

Related issues:
kubeflow/pipelines#3389
kubeflow/pipelines#2455

Description of your changes:
Sync the permission from kubeflow/pipeline to kubeflow/manifests

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot

kubeflow-bot commented Mar 30, 2020

Copy link
Copy Markdown
Contributor

This change is Reviewable

@Jeffwan Jeffwan force-pushed the pipeline-runner-role branch from ff2d42d to 81b1230 Compare April 9, 2020 23:29
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Apr 9, 2020
@Jeffwan Jeffwan force-pushed the pipeline-runner-role branch from 81b1230 to cc2121d Compare April 9, 2020 23:46
@k8s-ci-robot k8s-ci-robot added size/M and removed size/L labels Apr 9, 2020
@Jeffwan Jeffwan mentioned this pull request Apr 9, 2020
Closed
8 tasks
@Jeffwan

Jeffwan commented Apr 10, 2020

Copy link
Copy Markdown
Member Author

/assign @richardsliu release candidate for v1.0.2

@Jeffwan

Jeffwan commented Apr 10, 2020

Copy link
Copy Markdown
Member Author

/cc @Bobgy as well

@k8s-ci-robot k8s-ci-robot requested a review from Bobgy April 10, 2020 22:57
@k8s-ci-robot

k8s-ci-robot commented Apr 10, 2020

Copy link
Copy Markdown
Contributor

@Jeffwan: GitHub didn't allow me to request PR reviews from the following users: as, well.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @Bobgy as well

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bobgy
Bobgy reviewed Apr 11, 2020
View reviewed changes

@Bobgy Bobgy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Comment thread pipeline/pipelines-runner/base/cluster-role.yaml
resources:
- virtualservices
verbs:
- '*' No newline at end of file

@Bobgy Bobgy Apr 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: always newline at end of file

@richardsliu

richardsliu commented Apr 13, 2020

Copy link
Copy Markdown
Contributor

/approve

@k8s-ci-robot

k8s-ci-robot commented Apr 13, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan

Jeffwan commented Apr 14, 2020

Copy link
Copy Markdown
Member Author

/test kubeflow-manifests-presubmit

@Jeffwan
Update resources in pipeline-runner role
28d2b82 
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
@Jeffwan Jeffwan force-pushed the pipeline-runner-role branch from cc2121d to 28d2b82 Compare April 14, 2020 20:39
@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 14, 2020
@richardsliu

richardsliu commented Apr 14, 2020

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit e8a4489 into kubeflow:master Apr 14, 2020
@Jeffwan Jeffwan deleted the pipeline-runner-role branch April 14, 2020 21:50
Jeffwan added a commit to Jeffwan/manifests that referenced this pull request Apr 15, 2020
@Jeffwan
Update resources in pipeline-runner role (kubeflow#1060)
12bd4a9 
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
@Jeffwan Jeffwan mentioned this pull request Apr 15, 2020
Merged
1 task
k8s-ci-robot pushed a commit that referenced this pull request Apr 15, 2020
@Jeffwan
Cherry-pick #1041 #1060 #1081 to v1.0-branch (#1105)
95f88c1 
* Update resources in pipeline-runner role (#1060)

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>

* Update AWS storage options to 1.14 CSI compatible (#1081)

* add knative and kfserving in AWS kfdef (#1041)

* add knative and kfserving in AWS kfdef

* add knative and kfserving in AWS kfdef

* add knative, kfserving and gateway in v1.0.2

* revert changes on versions previous than v1.0.2

* run build_kfdef_specs and revert previous versions
@PatrickXYS PatrickXYS mentioned this pull request Apr 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@krishnadurai krishnadurai Awaiting requested review from krishnadurai

1 more reviewer

@Bobgy Bobgy Bobgy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Bobgy Bobgy

@richardsliu richardsliu

Labels

approved cla: yes lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Jeffwan @kubeflow-bot @k8s-ci-robot @richardsliu @Bobgy @googlebot