Skip to content

Update AWS storage options to 1.14 CSI compatible#1081

Merged
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
Jeffwan:aws_storage_update
Apr 14, 2020
Merged

Update AWS storage options to 1.14 CSI compatible#1081
k8s-ci-robot merged 1 commit into
kubeflow:masterfrom
Jeffwan:aws_storage_update

Conversation

@Jeffwan

@Jeffwan Jeffwan commented Apr 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Update AWS storage options to 1.14 CSI compatible

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot

kubeflow-bot commented Apr 7, 2020

Copy link
Copy Markdown
Contributor

This change is Reviewable

@Jeffwan Jeffwan mentioned this pull request Apr 7, 2020
Closed
@Jeffwan

Jeffwan commented Apr 7, 2020

Copy link
Copy Markdown
Member Author

/cc @richardsliu

a candidate for v1.0.2

@k8s-ci-robot k8s-ci-robot requested a review from richardsliu April 7, 2020 23:49
@Jeffwan Jeffwan mentioned this pull request Apr 9, 2020
Closed
8 tasks
@PatrickXYS

PatrickXYS commented Apr 10, 2020

Copy link
Copy Markdown
Member

/lgtm

@k8s-ci-robot

k8s-ci-robot commented Apr 10, 2020

Copy link
Copy Markdown
Contributor

@PatrickXYS: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickXYS

PatrickXYS commented Apr 10, 2020

Copy link
Copy Markdown
Member

@richardsliu It looks good to me, can you take a look?

@sublimotion

sublimotion commented Apr 11, 2020

Copy link
Copy Markdown

Looks good to me.

@richardsliu

richardsliu commented Apr 11, 2020

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot

k8s-ci-robot commented Apr 11, 2020

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan

Jeffwan commented Apr 12, 2020

Copy link
Copy Markdown
Member Author

/test kubeflow-manifests-presubmit

@Jeffwan

Jeffwan commented Apr 12, 2020

Copy link
Copy Markdown
Member Author 
go: finding github.com/kr/logfmt v0.0.0-20140226030751-b84e30acd515
go: finding github.com/gobuffalo/envy v1.6.5
go: finding github.com/matttproud/golang_protobuf_extensions v1.0.1
go: finding github.com/coreos/go-systemd v0.0.0-20180511133405-39ca1b05acc7
go: finding github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc
go: error loading module requirements
make: *** [modules] Error 1
Makefile:35: recipe for target 'modules' failed

util.py                     72 INFO     go: finding modernc.org/cc v1.0.0
util.py                     72 INFO     go: error loading module requirements
util.py                     72 INFO     Makefile:71: recipe for target 'generate' failed
util.py                     72 INFO     make: *** [generate] Error 1
=============================== warnings summary ===============================
kfctl_go_test.py::test_build_kfctl_go

Seems it's failed to build kfctl

@Jeffwan

Jeffwan commented Apr 13, 2020

Copy link
Copy Markdown
Member Author

/test kubeflow-manifests-presubmit

1 similar comment
@Jeffwan

Jeffwan commented Apr 14, 2020

Copy link
Copy Markdown
Member Author

/test kubeflow-manifests-presubmit

@Jeffwan Jeffwan force-pushed the aws_storage_update branch from 7d75795 to fd55647 Compare April 14, 2020 20:38
@k8s-ci-robot k8s-ci-robot removed the lgtm label Apr 14, 2020
@richardsliu

richardsliu commented Apr 14, 2020

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 3600052 into kubeflow:master Apr 14, 2020
Jeffwan added a commit to Jeffwan/manifests that referenced this pull request Apr 15, 2020
@Jeffwan
Update AWS storage options to 1.14 CSI compatible (kubeflow#1081)
c856906
@Jeffwan Jeffwan mentioned this pull request Apr 15, 2020
Merged
1 task
k8s-ci-robot pushed a commit that referenced this pull request Apr 15, 2020
@Jeffwan
Cherry-pick #1041 #1060 #1081 to v1.0-branch (#1105)
95f88c1 
* Update resources in pipeline-runner role (#1060)

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>

* Update AWS storage options to 1.14 CSI compatible (#1081)

* add knative and kfserving in AWS kfdef (#1041)

* add knative and kfserving in AWS kfdef

* add knative and kfserving in AWS kfdef

* add knative, kfserving and gateway in v1.0.2

* revert changes on versions previous than v1.0.2

* run build_kfdef_specs and revert previous versions
@Jeffwan Jeffwan mentioned this pull request Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@animeshsingh animeshsingh Awaiting requested review from animeshsingh

@IronPan IronPan Awaiting requested review from IronPan

@richardsliu richardsliu Awaiting requested review from richardsliu

Assignees

@richardsliu richardsliu

Labels

approved cla: yes lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Jeffwan @kubeflow-bot @PatrickXYS @k8s-ci-robot @sublimotion @richardsliu @googlebot