-
-
Notifications
You must be signed in to change notification settings - Fork 25
Only set 'syn-sync' when it is the main syntax #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR tries another approach and sets a flag in the files which include the nested syntax. I tested with
For php files I also tested that the nested syntax is still working. Very nice feature to have! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think there's a good way to write a test for this behavior to prevent future regressions?
I added a test which checks for the '500' in the syntax setting. |
The test checks now for the exact value which would be set if there is a regression. The downside is, the test has to be changed whenever the value "500" is changed or the string format changes. The upside is, it shouldn't fail as a false positive. I had to store the result of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I'll give it a final look over the weekend and then merge.
Thanks for this, @pjio! I appreciate you digging in to the issue and producing a generalized solution to the problem. |
No description provided.