Skip to content

Removes sync minlines from syntax file #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Removes sync minlines from syntax file #71

wants to merge 1 commit into from

Conversation

pjio
Copy link
Contributor

@pjio pjio commented Dec 1, 2020

This setting breaks the syntax coloring in large PHP files for me. It's run via after/syntax/php/graphql.vim so due to similar files for other languages those might be affected as well (I have tested only PHP).

I'm not totally sure if ftplugin/graphql.vim might be a better place to set the value or if it shouldn't be overwritten at all.

At least I can say that setting the value inside the syntax file can cause a problem:

Steps to reproduce:

  1. Open a large PHP file, e.g. https://raw.githubusercontent.com/WordPress/WordPress/master/wp-includes/ID3/getid3.lib.php
  2. Jump to Line 1000 with :1000<cr>
  3. The syntax coloring is broken

@jparise jparise self-assigned this Dec 1, 2020
@jparise jparise added the bug label Dec 1, 2020
@jparise
Copy link
Owner

jparise commented Dec 1, 2020

@pjio could you check if #72 fixes the problem you're seeing?

@jparise
Copy link
Owner

jparise commented Dec 2, 2020

Closing in favor of #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants