Skip to content

Only set 'syn-sync' when we're the main syntax #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

jparise
Copy link
Owner

@jparise jparise commented Dec 1, 2020

This should avoid problems when the GraphQL syntax is embedded within an
outer syntax. In those cases, we don't want to change the syntax sync
setting.

This should avoid problems when the GraphQL syntax is embedded within an
outer syntax. In those cases, we don't want to change the syntax sync
setting.
@pjio
Copy link
Contributor

pjio commented Dec 2, 2020

I tested the commit but it didn't solve the problem. I looked at other syntax plugins and it seems usual to set syn sync in the syntax script, so I made another PR which skips this part if the syntax is included as a nested syntax: #73

@jparise
Copy link
Owner Author

jparise commented Dec 2, 2020

Closing in favor of #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants