Skip to content

Conversation

@janfaracik
Copy link
Member

@janfaracik janfaracik commented Oct 15, 2025

image image

This PR adds an experimental dashboard UI, hidden behind a flag, in line with the new job and run pages.

What's new?

  • New design, consistent with jobs and builds
  • Trying to reduce Jelly duplication (E.g. folder plugin duplicates stuff from core, would be good not to)
  • App bar supports icons, so plugins don't need to implement that themselves
  • Support for icons/badges for tabs

There'll be more to come/more polish in future iterations.

Testing done

  • UI isn't ideal at the moment, but it is functional

Proposed changelog entries

  • Add experimental dashboard UI

Proposed changelog category

/label web-ui,rfe

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@comment-ops-bot comment-ops-bot bot added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Oct 15, 2025
@janfaracik janfaracik requested a review from a team October 16, 2025 14:28
@janfaracik janfaracik marked this pull request as ready for review October 16, 2025 14:28
@janfaracik janfaracik added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Oct 16, 2025
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much better.

There is one layout shift but probably not a big deal:

Dashboard:

image

A view:
image

Note that the All view is in a much different place, this happens due to the edit view button. Probably can be a small fix-up later.

@timja timja requested a review from a team October 22, 2025 07:53
@timja
Copy link
Member

timja commented Oct 22, 2025

Can you create an issue tracking post in sig-ux and a feedback post on community.jenkins.io as well?

@janfaracik janfaracik mentioned this pull request Nov 24, 2025
3 tasks
@janfaracik janfaracik requested a review from NotMyFault October 23, 2025 12:35
Copy link
Contributor

@lewisbirks lewisbirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@timja
Copy link
Member

timja commented Oct 23, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 23, 2025
@timja
Copy link
Member

timja commented Oct 23, 2025

Noting #18530 for tracking of feedback from this

@timja timja merged commit 8c385f4 into jenkinsci:master Oct 26, 2025
18 checks passed
@timja timja deleted the experimental-dashboard-page branch October 26, 2025 22:14
@bpedersen2
Copy link
Contributor

There is a incompatibility with the Dashboard View plugin, you get the configured tabs displayed twice, see screenshot
FireShot Capture 016 - Dashboard - Jenkins

@timja
Copy link
Member

timja commented Oct 29, 2025

@janfaracik this fails PCT are you able to check the groovy test failures here please:
https://ci.jenkins.io/job/Tools/job/bom/job/PR-5906/1/testReport/

@janfaracik janfaracik mentioned this pull request Oct 30, 2025
14 tasks
Comment on lines -21 to 30

#side-panel .pane-header,
#side-panel .pane-footer {
.pane-header,
.pane-footer {
color: var(--link-dark-color);
background: transparent;
padding: 0.65rem 1rem;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes conflict with the CSS already present in

since #side-panel is no longer present and is causing some broken UI when we use panel-header

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing legacy tables?

Maybe we change l:pane to use jenkins-pane-header and revert this change.

@janfaracik what was the reason to remove this? As I expect the pane's are still only used in the sidepanel legitimately.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you post a screenshot of the broken pane?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janfaracik what was the reason to remove this? As I expect the pane's are still only used in the sidepanel legitimately.

The widgets on the experimental dashboard aren't inside their usual #side-panel container. Also wanted to standardise the code for widgets.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
image
After
image

I narrowed it down to specifically the change in adding display:flex as reverting just this fixes the entire issue. I dont know exactly why as i am not that familiar with UI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a revert PR, as its difficult to override this in child CSS, i am not sure of the impact on the dashboard changes #11272

@NotMyFault
Copy link
Member

How do you edit the description of the default view? Enabling the flag, I see no "Edit View" button on https://weekly.ci.jenkins.io, if the view is the default view.

@timja
Copy link
Member

timja commented Nov 11, 2025

How do you edit the description of the default view? Enabling the flag, I see no "Edit View" button on weekly.ci.jenkins.io, if the view is the default view.

Looks to be missing (other than doing via JCasc) - I added it to the tracking issue: #18530

@NotMyFault
Copy link
Member

Screenshot 2025-11-14 at 22 15 37

The "Changes" card looks like that, though there is a changeset in the build:
Screenshot 2025-11-14 at 22 16 42

@timja
Copy link
Member

timja commented Nov 14, 2025

That was fixed in #11277 (merged 2 days not released yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted squash-merge-me Unclean or useless commit history, should be merged only with squash-merge web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants