-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add experimental dashboard UI #11208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental dashboard UI #11208
Conversation
Co-authored-by: Tim Jacomb <[email protected]>
timja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Can you create an issue tracking post in sig-ux and a feedback post on community.jenkins.io as well? |
lewisbirks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
|
Noting #18530 for tracking of feedback from this |
|
@janfaracik this fails PCT are you able to check the groovy test failures here please: |
|
|
||
| #side-panel .pane-header, | ||
| #side-panel .pane-footer { | ||
| .pane-header, | ||
| .pane-footer { | ||
| color: var(--link-dark-color); | ||
| background: transparent; | ||
| padding: 0.65rem 1rem; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes conflict with the CSS already present in
| .pane-header, |
#side-panel is no longer present and is causing some broken UI when we use panel-header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing legacy tables?
Maybe we change l:pane to use jenkins-pane-header and revert this change.
@janfaracik what was the reason to remove this? As I expect the pane's are still only used in the sidepanel legitimately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you post a screenshot of the broken pane?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janfaracik what was the reason to remove this? As I expect the pane's are still only used in the sidepanel legitimately.
The widgets on the experimental dashboard aren't inside their usual #side-panel container. Also wanted to standardise the code for widgets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I narrowed it down to specifically the change in adding display:flex as reverting just this fixes the entire issue. I dont know exactly why as i am not that familiar with UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a revert PR, as its difficult to override this in child CSS, i am not sure of the impact on the dashboard changes #11272
|
How do you edit the description of the default view? Enabling the flag, I see no "Edit View" button on https://weekly.ci.jenkins.io, if the view is the default view. |
Looks to be missing (other than doing via JCasc) - I added it to the tracking issue: #18530 |
|
That was fixed in #11277 (merged 2 days not released yet) |







This PR adds an experimental dashboard UI, hidden behind a flag, in line with the new job and run pages.
What's new?
There'll be more to come/more polish in future iterations.
Testing done
Proposed changelog entries
Proposed changelog category
/label web-ui,rfe
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered (see query).