Revert display:flex added to pane-header

[RanjitCS]

In #11208, display:flex was added to the default panel-header css which is causing UI to break. Overriding this is child css is difficult, so suggesting to just revert this change for now

Before

After

Testing done

Proposed changelog entries

• Revert panel-header display:flex.

Proposed changelog category

/label regression-fix

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[welcome]

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

[mawinter69]

Not sure what you intend to fix, but the before screenshot doesn't look wrong to me. From which plugin is this?

[RanjitCS]

Not sure what you intend to fix, but the before screenshot doesn't look wrong to me. From which plugin is this?

Its a private plugin, but essentially https://github.com/jenkinsci/jenkins/pull/11208/files#diff-589da5428ad7e66ca76d06f4b961671e7773a4f0bdde09b8d6f9f0dce095c5d2R15-R19 this change introduces new CSS to panel-header which breaks UI.

I am not sure i get what you mean here, as the after screenshot shows that the after this change the panel-header becomes a column instead of row.

[mawinter69]

I guess your before screen shot is what was the state before #11208 and not before your fix. That's a bit confusing.
Not sure if we should care about private plugins though. It's probably better if you adjust your plugin to use modern Jenkins styling. I mean this looks totally out of sync with what we have nowadays.

[Wadeck]

Not sure if we should care about private plugins though

While I agree with you in general, but when there is a User experimental flag I would expect that there is no breaking change if it's disabled. That's the goal of the feature flag, delivering something, to let users test it and provide feedback. That approach is the way to move fast with changes, and once we reach a good (voluntary) adoption rate and less and less error reports, it can be enabled by default.
Otherwise, you have to ensure to provide backward compatibility OR a lot more tooling / support around the changes (and thus reducing the pace of delivery)

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[welcome]

Congratulations on getting your very first Jenkins core pull request merged 🎉🥳

This is a fantastic achievement, and we're thrilled to have you as part of our community! Thank you for your valuable input, and we look forward to seeing more of your contributions in the future!

We would like to invite you to join the community chats and forums to meet other Jenkins contributors 😊
Don't forget to check out the participation page to learn more about how to contribute to Jenkins.

[daniel-beck]

Not sure if we should care about private plugins though.

matrix-auth on 2.535: