Refine Changes for the experimental Run UI

[janfaracik]

Feedback

If you have feedback the recommended place to provide it is jenkinsci/sig-ux#7 or https://community.jenkins.io/t/a-redesigned-build-page-let-me-know-your-thoughts/35596/10

---

There was a difference in changes.jelly between Jenkins core and pipelines (workflow-job-plugin). This PR merges them, so we can do away with the now duplicated code in workflow-job.

Core (before this PR)

<j:choose>
  <j:when test="${it.hasChangeSetComputed()}">
    <st:include page="index.jelly" it="${it.changeSet}" />
  </j:when>
  <j:when test="${it.building}">
    ${%Not yet determined}
  </j:when>
  <j:otherwise>
    ${%Failed to determine} (<a href="${h.getConsoleUrl(it)}">${%log}</a>)
  </j:otherwise>
</j:choose>

Source: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/hudson/model/AbstractBuild/changes.jelly

workflow-job

<l:main-panel>
    <t:buildCaption>${%Changes}</t:buildCaption>
    <j:forEach var="changeSet" items="${it.changeSets}">
        <st:include page="index.jelly" it="${changeSet}"/>
    </j:forEach>
</l:main-panel>

Source: https://github.com/jenkinsci/workflow-job-plugin/blob/master/src/main/resources/org/jenkinsci/plugins/workflow/job/WorkflowRun/changes.jelly

• Removed duplication
• Tidied UI slightly for Changes tab
• Widget code now works and displays changes on the Overview tab
• Changes summary now hides in the experimental Run UI
• Changes link no longer visible in overflow menu in experimental Run UI

Before

After

Users won't see this tab, but I've updated the UI just in case they navigate directly to the URL

Testing done

• Freestyle jobs show their changes as expected
• The widget now works as expected

Proposed changelog entries

• Refine Changes for the experimental Run UI

Proposed changelog category

/label web-ui,rfe

Proposed upgrade guidelines

N/A

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[PhilippHomann]

Sorry for commenting here, but I don't have no Jira account actually.
Using the new Run UI I'm missing the list of artifacts attached to the Run.
Same for the Job UI where the artifacts of the last successful Run were shown in the past.

[timja]

Thanks for the feedback

Sorry for commenting here, but I don't have no Jira account actually.

We aren't tracking any of this on Jira, mostly either on jenkinsci/sig-ux#7 or https://community.jenkins.io/t/a-redesigned-build-page-let-me-know-your-thoughts/35596/10

Using the new Run UI I'm missing the list of artifacts attached to the Run.

There's a work in progress pull request here: #11278