-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[JENKINS-76114] Bring back the "All/None/Suggested" buttons in the plugin configuration wizard #11070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MarkEWaite
merged 1 commit into
jenkinsci:master
from
jeromepochat:fix-plugin-search-controls-margin
Sep 20, 2025
Merged
[JENKINS-76114] Bring back the "All/None/Suggested" buttons in the plugin configuration wizard #11070
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possible to add a test that suggested plugin link works?
its very rare for someone to use setup wizard while developing as its automatically skipped so something like this can slip through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "None" link is already in InstallWizardTest.wizardInstallSuggestedTest. I can update this test to cover "All" and "Suggested" links, but I don't understand why the CI didn't catch this issue for 2.527. 🤔
Running ATH locally fails:
JENKINS_VERSION=2.527 mvn test -Dtest=InstallWizardTest#wizardInstallCustomPluginsTest(pass with
JENKINS_VERSION=2.526)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If ATH already covers this then its fine, do you know what change broke it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I didn't get yet the root of the issue.
From 2.526...2.527 comparison, and focusing on
package.jsonchanges, I suspect the following bumps:postcss-loaderfrom 8.1.1 to 8.2.0saasfrom 1.91.0 to 1.92.1There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/jenkinsci/acceptance-test-harness/blob/6e177b3fc1cab5fa401f30f4ca7d741551c49269/src/main/java/org/jenkinsci/test/acceptance/po/WizardCustomizeJenkins.java#L97-L100 won't help, as the links are present, they're just overlaid by the search box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://stackoverflow.com/a/7525678 disagrees:
Have you tried it / found other sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it as part of jenkinsci/acceptance-test-harness#2178.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it did -> jenkinsci/acceptance-test-harness#2175
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/jenkinsci/acceptance-test-harness/runs/50269977447 because renovate is force pushing over PRs and the fail will eventually be hard to find when this PR is merged and released.