Skip to content

Conversation

@jeromepochat
Copy link
Contributor

This tests that "All" and "Suggested" button from plugin setup wizard are clickable ("None" link is already tested).

image

Testing done

Manual tests were performed as part of jenkinsci/jenkins#11070.

This extends coverage of the existing automated test. I tested locally:

JENKINS_VERSION=2.526 mvn test -Dtest=InstallWizardTest#wizardInstallCustomPluginsTest

⚠️ This is failing with 2.527 => jenkinsci/jenkins#11070 fixes the issue.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@timja timja added the tests label Sep 16, 2025
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test would appear to be flaky and performs actions without asserting anything

Comment on lines 96 to 98
wizardCustomize.searchPlugin("JUnit");
wizardCustomize.selectPlugin("junit");
wizardCustomize.startInstall();
Copy link
Member

@jtnord jtnord Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this is a weak test, as junit is a suggested plugin - so the customisation may be completely broken. (there is also no check that the plugin is installed later on!)

@jtnord jtnord merged commit 93969c7 into jenkinsci:master Oct 8, 2025
1 of 3 checks passed
@jeromepochat jeromepochat deleted the JENKINS-76114 branch October 8, 2025 12:04
Comment on lines +127 to +135
private boolean isSelected(String pluginKey) {
return driver
.findElements(by.xpath(
"//div[contains(@class, 'plugins-for-category')]/div[contains(@class, 'plugin') and contains(@class, 'selected') and contains(@class, '%s')]",
pluginKey))
.stream()
.findFirst()
.isPresent();
}
Copy link
Member

@jtnord jtnord Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeromepochat this fails for some plugins. e.g. workflow-aggregator

can be reproduced with

diff --git a/src/test/java/core/InstallWizardTest.java b/src/test/java/core/InstallWizardTest.java
index 2a8507cb..6d3da103 100644
--- a/src/test/java/core/InstallWizardTest.java
+++ b/src/test/java/core/InstallWizardTest.java
@@ -93,8 +93,8 @@ public class InstallWizardTest extends AbstractJUnitTest {
         wizardCustomize.selectSuggested();
         wizardCustomize.selectAll();
         wizardCustomize.selectNone();
-        wizardCustomize.searchPlugin("JUnit");
-        wizardCustomize.selectPlugin("junit");
+        wizardCustomize.searchPlugin("Pipeline");
+        wizardCustomize.selectPlugin("workflow-aggregator");
         wizardCustomize.startInstall();

         wizardCustomize.shouldFinishInstallSuccessfully();

@jtnord jtnord mentioned this pull request Oct 24, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants