Skip to content

[JENKINS-76114] Bring back the "All/None/Suggested" buttons in the plugin configuration wizard #11070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarkEWaite merged 1 commit into from
Sep 20, 2025
Merged

[JENKINS-76114] Bring back the "All/None/Suggested" buttons in the plugin configuration wizard #11070

MarkEWaite merged 1 commit into from
Sep 20, 2025

Conversation

@jeromepochat
Copy link
Contributor

@jeromepochat jeromepochat commented Sep 15, 2025 •
edited
Loading

See JENKINS-76114.

Since 2.527, the list of plugin in setup wizard does not show "All/None/Suggested" buttons.

Before:
image

After:
image

Testing done

❯ mvn -am -pl war,bom -Pquick-build clean install
❯ JENKINS_HOME=tmp java -jar war/target/jenkins.war

Checked that buttons are visible in both Chrome and Firefox

  • large screen (width > 768px) image
  • small screen (width <= 768px) image

Proposed changelog entries

  • Fix "All/None/Suggested" buttons visibility in plugin setup wizard.

Proposed changelog category

/label regression-fix

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@comment-ops-bot comment-ops-bot bot added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Sep 15, 2025
@NotMyFault NotMyFault requested a review from a team September 16, 2025 05:40
timja
timja reviewed Sep 16, 2025
View reviewed changes
src/main/scss/pluginSetupWizard.scss
top: 0;
right: 0;
left: 0;
padding: 0 10px;
Copy link
Member

@timja timja Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible to add a test that suggested plugin link works?

its very rare for someone to use setup wizard while developing as its automatically skipped so something like this can slip through.

Copy link
Contributor Author

@jeromepochat jeromepochat Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible to add a test that suggested plugin link works?

The "None" link is already in InstallWizardTest.wizardInstallSuggestedTest. I can update this test to cover "All" and "Suggested" links, but I don't understand why the CI didn't catch this issue for 2.527. 🤔

Running ATH locally fails:

JENKINS_VERSION=2.527 mvn test -Dtest=InstallWizardTest#wizardInstallCustomPluginsTest

(pass with JENKINS_VERSION=2.526)

Copy link
Member

@timja timja Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ATH already covers this then its fine, do you know what change broke it?

Copy link
Contributor Author

@jeromepochat jeromepochat Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ATH already covers this then its fine, do you know what change broke it?

TBH, I didn't get yet the root of the issue.

From 2.526...2.527 comparison, and focusing on package.json changes, I suspect the following bumps:

  • postcss-loader from 8.1.1 to 8.2.0
  • saas from 1.91.0 to 1.92.1

Copy link
Member

@daniel-beck daniel-beck Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jenkinsci/acceptance-test-harness/blob/6e177b3fc1cab5fa401f30f4ca7d741551c49269/src/main/java/org/jenkinsci/test/acceptance/po/WizardCustomizeJenkins.java#L97-L100 won't help, as the links are present, they're just overlaid by the search box.

Copy link
Member

@daniel-beck daniel-beck Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/a/7525678 disagrees:

at least in my test, it does not reliably detect if an element is covered by another due to CSS positioning.

Have you tried it / found other sources?

Copy link
Contributor Author

@jeromepochat jeromepochat Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried it / found other sources?

I tried it as part of jenkinsci/acceptance-test-harness#2178.

Copy link
Member

@jtnord jtnord Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I don't understand why the CI didn't catch this issue for 2.527. 🤔

it did -> jenkinsci/acceptance-test-harness#2175

Copy link
Member

@daniel-beck daniel-beck Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice:

Element <a class="plugin-select-none" href="#"> is not clickable at point (643,92) because another element <input class="form-control" name="searchbox" type="text"> obscures it

Copy link
Member

@jtnord jtnord Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jenkinsci/acceptance-test-harness/runs/50269977447 because renovate is force pushing over PRs and the fail will eventually be hard to find when this PR is merged and released.

@jeromepochat jeromepochat mentioned this pull request Sep 16, 2025
Merged
6 tasks
MarkEWaite
MarkEWaite approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.

/label ready-for-merge

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 19, 2025
@MarkEWaite MarkEWaite merged commit 02b40b1 into jenkinsci:master Sep 20, 2025
17 of 18 checks passed
@jeromepochat jeromepochat deleted the fix-plugin-search-controls-margin branch September 21, 2025 12:46
lemeurherve pushed a commit to lemeurherve/jenkins that referenced this pull request Sep 29, 2025
@jeromepochat @lemeurherve
[JENKINS-76114] Bring back the "All/None/Suggested" buttons in the pl…
63bcbfd 
…ugin configuration wizard (jenkinsci#11070)

Fix padding

(cherry picked from commit 02b40b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtnord jtnord jtnord left review comments

@daniel-beck daniel-beck daniel-beck left review comments

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@timja timja timja approved these changes

Assignees

No one assigned

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeromepochat @MarkEWaite @jtnord @daniel-beck @timja