Skip to content

Fix WizardCustomizeJenkins#2215

Merged
jtnord merged 2 commits intojenkinsci:masterfrom
jtnord:wizard-po-failure
Oct 24, 2025
Merged

Fix WizardCustomizeJenkins#2215
jtnord merged 2 commits intojenkinsci:masterfrom
jtnord:wizard-po-failure

Conversation

@jtnord
Copy link
Member

@jtnord jtnord commented Oct 24, 2025

#2178 (comment)

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@jtnord jtnord changed the title Add Pipeline to the Unit tests to show failure Fix WizardCustomizeJenkins Oct 24, 2025
.stream()
.findFirst()
.isPresent();
return driver.findElement(by.id("chk-" + pluginKey)).isSelected();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before this change

org.openqa.selenium.TimeoutException: Expected condition failed: waiting for org.jenkinsci.test.acceptance.po.WizardCustomizeJenkins$$Lambda/0x000001d0bb40d188@25b38203 (tried for 1 second(s) with 500 milliseconds interval)
Build info: version: '4.37.0', revision: '3c1da1e342'
System info: os.name: 'Windows 11', os.arch: 'amd64', os.version: '10.0', java.version: '21.0.1'
Driver info: driver.version: unknown
        at org.openqa.selenium.support.ui.FluentWait.timeoutException(FluentWait.java:265)
        at org.jenkinsci.test.acceptance.junit.Wait.timeoutException(Wait.java:191)
        at org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:228)
        at org.jenkinsci.test.acceptance.junit.Wait.until(Wait.java:120)
        at org.jenkinsci.test.acceptance.po.WizardCustomizeJenkins.selectPlugin(WizardCustomizeJenkins.java:91)
        at core.InstallWizardTest.wizardInstallCustomPluginsTest(InstallWizardTest.java:99)

presumably something to do with the - in the plugin name interacting badly with the css selector, but well we have a stable ID for the checkbox so rather than searching the dom go directly.

@jtnord jtnord added the bug label Oct 24, 2025
@jtnord jtnord requested a review from jeromepochat October 24, 2025 17:11
@jtnord jtnord marked this pull request as ready for review October 24, 2025 17:12
@jtnord jtnord enabled auto-merge October 24, 2025 17:23
@jtnord jtnord merged commit 20a0c19 into jenkinsci:master Oct 24, 2025
24 checks passed
@jtnord jtnord deleted the wizard-po-failure branch October 24, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant