Skip to content

Fixed an issue where pasting long text and typing in the middle moved the cursor to the end. #2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 21, 2024
Merged

Fixed an issue where pasting long text and typing in the middle moved the cursor to the end. #2927

merged 14 commits into from
Oct 21, 2024

Conversation

Ahmed-Naguib93
Copy link
Contributor

@Ahmed-Naguib93 Ahmed-Naguib93 commented Oct 11, 2024 •
edited by rh12
Loading

refs: MBL-17838
affects: Student , Teacher
release note: Fixed issues after pasting long text in inbox messages.

Fixed an issue where pasting long text and typing in the middle moved the cursor to the end.

Test Plane

1- Open new message.
2- Set long text.
3- Start type in the middle on the text and set new line will work fine.

Screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-11.at.13.51.35.mp4

Checklist

  • Tested on phone
  • Tested on tablet
  • Tested on iOS 17
  • Tested on iOS 18

@Ahmed-Naguib93
Typing in long pasted text moves the cursor to the end
80fcf08 
refs:MBL-17838
affects:Student, Teacher
release note: Moved the cursor to the end when pasting long text

test plan:
@Ahmed-Naguib93
Move move courser to end
f5432f2 
refs:MBL-17838
affects:Student, Teacher
release note: Moved the cursor to the end when pasting long text

test plan:
@inst-danger
Copy link
Contributor

inst-danger commented Oct 11, 2024 •
edited
Loading

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Oct 11, 2024 •
edited
Loading

Student Build QR Code:

@Ahmed-Naguib93 Ahmed-Naguib93 self-assigned this Oct 11, 2024
@inst-danger
Copy link
Contributor

inst-danger commented Oct 11, 2024 •
edited by jira bot
Loading

Warnings
⚠️ One or more files are below the minimum test coverage 50%

Release Note:

Fixed an issue where pasting long text and typing in the middle moved the cursor to the end.

Affected Apps: Student, Teacher

MBL-17838

Coverage New % Master % Delta
Canvas iOS 91.18% 91.18% -0%
Core/Core/Planner/CalendarEvent/Model/API/PostCalendarEventRequest.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/View/CustomFrequencyComponents/OccurrencesCountInputDialog.swift 0% 0% 0%
Core/Core/Planner/CalendarEvent/Model/Helpers/RecurrenceRule+SelectionDescription.swift 43.33% 43.33% 0%
Core/Core/Grades/View/CustomSwipeAction.swift 0% 0% 0%

Generated by 🚫 dangerJS against 18d0f50

vargaat
vargaat requested changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this strange behavior on iOS 17.5.1. Besides that, I think we can't just scroll to the end of the text (where attachments are) because the user is not necessarily pasting text at the end of the message. The original bug was about when you enter some characters after pasting a long text the characters are not entered to where the cursor is visible but instead at the end of the document. If we could fix that alone would be enough, if we could scroll to the end of the pasted text that would nice to have.

RPReplay_Final1728996199.MP4

@Ahmed-Naguib93
Fix issue in past text for inbox
97306db 
refs: MBL-17838
affects: Student , Teacher
release note: Moved the cursor to the end when pasting long text

test plan:
@Ahmed-Naguib93
fix swiftLint issue
73c6009 
refs:MBL-17838
affects:Student , Teacher
release note:Moved the cursor to the end when pasting long text

test plan:
@Ahmed-Naguib93
Fix past long text
42af1cf 
refs:MBL-17838
affects:Student , Teacher
release note:Moved the cursor to the end when pasting long text

test plan:
@Ahmed-Naguib93
Copy link
Contributor Author

Ahmed-Naguib93 commented Oct 15, 2024 •
edited
Loading

I get this strange behavior on iOS 17.5.1. Besides that, I think we can't just scroll to the end of the text (where attachments are) because the user is not necessarily pasting text at the end of the message. The original bug was about when you enter some characters after pasting a long text the characters are not entered to where the cursor is visible but instead at the end of the document. If we could fix that alone would be enough, if we could scroll to the end of the pasted text that would nice to have.

RPReplay_Final1728996199.MP4

Thanks for your comment and your are right. The issue is now fixed, but I removed the feature that scrolls to the bottom when pasting text. It was misleading because if the text was pasted in the middle, it would incorrectly scroll to the bottom.

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-10-15.at.23.42.27.mp4

@Ahmed-Naguib93
Fix indentation
92ea918 
refs:MBL-17838
affects:Student , Teacher
release note:Moved the cursor to the end when pasting long text

test plan:
@Ahmed-Naguib93
Fix issue in iOS18
37151a9 
refs:MBL-17838
affects:Student , Teacher
release note: Fixed an issue where pasting long text and typing in the middle moved the cursor to the end.

test plan:
@Ahmed-Naguib93 Ahmed-Naguib93 changed the title Move the cursor to the end when pasting long text Fixed an issue where pasting long text and typing in the middle moved the cursor to the end. Oct 15, 2024
@Ahmed-Naguib93
Fix past issues
294b6d6 
refs:MBL-17838
affects:Student , Teacher
release note:Fixed an issue where pasting long text and typing in the middle moved the cursor to the end.

test plan:
@Ahmed-Naguib93
Fix swiftlint issues
e444057 
refs:MBL-17838
affects:Student , Teacher
release note: Fixed an issue where pasting long text and typing in the middle moved the cursor to the end.

test plan:
@Ahmed-Naguib93
Update for CI
15cd769 
refs:MBL-17838
affects:Student , Teacher
release note: Fixed an issue where pasting long text and typing in the middle moved the cursor to the end.

test plan:
@Ahmed-Naguib93
Use textEditor instead
4e00178 
refs:MBL-17838
affects:Student , Teacher
release note:Fixed an issue where pasting long text and typing in the middle moved the cursor to the end.

test plan:
@Ahmed-Naguib93
Update for CI
544c128 
refs: MBL-17838
affects: Student , Teacher
release note: Fixed an issue where pasting long text and typing in the middle moved the cursor to the end.

test plan:
@Ahmed-Naguib93
fix conflicts
9dca192 
refs:MBL-17838
affects: Student , Teacher
release note: Fixed an issue where pasting long text and typing in the middle moved the cursor to the end.

test plan:
rh12
rh12 reviewed Oct 17, 2024
View reviewed changes
@Ahmed-Naguib93
Remove white lines
18d0f50 
refs:MBL-17838
affects: Student , Teacher
release note:Fixed an issue where pasting long text and typing in the middle moved the cursor to the end.

test plan:
@Ahmed-Naguib93 Ahmed-Naguib93 requested a review from rh12 October 17, 2024 10:28
rh12
rh12 requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1
The original issue is fixed, but there is a known issue with InstUI.TextEditorCell on iOS 17.
It's mentioned in the PR introducing it, but please add this text to the code:
As a doc comment just before InstUI.TextEditorCell:

    /// Known issue on iOS 17 (but not on iOS 16):
    ///   TextEditor jumps to the top, when the top was already scrolled out of view, and some text is pasted at or near the bottom.
    ///   Continuing typing jumps back to the cursor, which stayed correctly at the end of the pasted text.

Please test this behaviour on iOS 18 as well, if you can, and add that to the doc comment accordingly. (I only have iOS 17 test devices at the moment)

@Ahmed-Naguib93
Copy link
Contributor Author

InstUI.TextEditorCell on iOS 17.

Yes, I have tested it on iOS 18.0.1, and it is working fine. This is a standard UITextView, an older controller.

@rh12
Copy link
Contributor

rh12 commented Oct 17, 2024

Yes, I have tested it on iOS 18.0.1, and it is working fine. This is a standard UITextView, an older controller.

Sorry, I tested the right thing, but wrote about the other thing... anyway, please disregard the PR comment above about the doc comment in code.

Approving

szabinst
szabinst approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@szabinst szabinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

suhaibabsi-inst
suhaibabsi-inst approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

@rh12 rh12 merged commit 42959c9 into master Oct 21, 2024
5 checks passed
@rh12 rh12 deleted the feature/MBL-17838-Typing-in-long-pasted-text-moves-the-cursor-to-the-end branch October 21, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rh12 rh12 rh12 approved these changes

@vargaat vargaat vargaat approved these changes

@szabinst szabinst szabinst approved these changes

@suhaibabsi-inst suhaibabsi-inst suhaibabsi-inst approved these changes

@ndrsszsz ndrsszsz Awaiting requested review from ndrsszsz ndrsszsz is a code owner

Assignees

@Ahmed-Naguib93 Ahmed-Naguib93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ahmed-Naguib93 @inst-danger @rh12 @vargaat @szabinst @suhaibabsi-inst